brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: OSGi/catalog improvements
Date Wed, 09 Jul 2014 16:13:37 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/47#discussion_r14718985
  
    --- Diff: usage/rest-server/src/main/java/brooklyn/rest/resources/CatalogResource.java
---
    @@ -98,6 +100,20 @@ public Response create(String yaml) {
             }
         }
     
    +    public Response resetXml(String xml) {
    +        ((BasicBrooklynCatalog)mgmt().getCatalog()).reset(CatalogDto.newDtoFromXmlContents(xml,
"REST reset"));
    --- End diff --
    
    Agree, some methods are in wrong place, and there are a lot of casts I don't like.  However
the catalog subsystem will continue to be dramatically changed as we move to YAML catalog
so not spending too much time on this just now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message