brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nakomis <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Date Wed, 09 Jul 2014 14:07:13 GMT
Github user Nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48475389
  
    @aledsage this appears to be due to Rat's behaviour changing depending on the value of
`System.getProperty("file.encoding")`. See the `isBinary(InputStream in)` method in [1]. @richardcloudsoft
and I debugged this during review and Richard has added these files as exclusions. 
    
    To ensure that it is this, can you try `mvn apache-rat:check -Dfile.encoding=UTF8`, which
should work and `mvn apache-rat:check -Dfile.encoding=ISO8859_1` which should fail
    
    Also, as #43 is being reverted, we'll need to wait until #56 is merged
    
    [1]: http://svn.apache.org/repos/asf/creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/BinaryGuesser.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message