brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Improvements to the jsgui catalog...
Date Wed, 09 Jul 2014 12:59:51 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/51#discussion_r14707693
  
    --- Diff: usage/rest-server/src/main/java/brooklyn/rest/resources/LocationResource.java
---
    @@ -77,25 +84,25 @@ public LocationSummary apply(LocationDefinition l) {
               result.put(l.getId(), m);
           }
           return result;
    -  }
    +    }
     
       /** @deprecated since 0.7.0; REST call now handled by below (optional query parameter
added) */
       public LocationSummary get(String locationId) {
           return get(locationId, false);
       }
    -  
    +
       @Override
       public LocationSummary get(String locationId, String fullConfig) {
           return get(locationId, Boolean.valueOf(fullConfig));
       }
    -  
    +
       public LocationSummary get(String locationId, boolean fullConfig) {
    --- End diff --
    
    Good to get consistent 4 spaces in your edits. Looks like some old code is still 2 spaces
though. Don't bother changing in this PR, but we should really change it across the board
in a simple PR where it is only white space that is changing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message