brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From richardcloudsoft <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Date Wed, 09 Jul 2014 12:42:11 GMT
Github user richardcloudsoft commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14706961
  
    --- Diff: software/nosql/pom.xml ---
    @@ -159,5 +159,23 @@
                 <scope>test</scope>
             </dependency>
         </dependencies>
    -
    +    <build>
    +      <pluginManagement>
    +        <plugins>
    +          <plugin>
    +            <groupId>org.apache.rat</groupId>
    +            <artifactId>apache-rat-plugin</artifactId>
    +            <version>0.10</version>
    +            <configuration>
    +              <excludes combine.children="append">
    +                <exclude>**/couchdb/couch.uri</exclude>
    +                <exclude>**/riak/vm.args</exclude>
    --- End diff --
    
    @aledsage agreed. However that should not stop us merging this PR, which is designed to
stop any future infractions before they even become PRs. There are known cases in the current
code where we have license compliance issues so we should deal with `couch.uri` and other
suspicious exclusions at that time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message