brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Couchbase sync gateway
Date Wed, 09 Jul 2014 09:54:23 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/25#discussion_r14701467
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseSyncGatewayDriver.java
---
    @@ -0,0 +1,9 @@
    +package brooklyn.entity.nosql.couchbase;
    +
    +import brooklyn.entity.basic.SoftwareProcessDriver;
    +
    +public interface CouchbaseSyncGatewayDriver extends SoftwareProcessDriver {
    +
    +    public String getOsTag();
    --- End diff --
    
    Worth javadoc to say what format result will be - it's used in freemarker for building
`CouchbaseSyncGateway.DOWNLOAD_URL` (hence me being ok with it being on the interface). That
download url will have strict requirements for what format osTag needs to be in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message