brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Couchbase sync gateway
Date Tue, 08 Jul 2014 16:34:40 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/25#discussion_r14663845
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseClusterImpl.java
---
    @@ -315,6 +341,81 @@ public boolean isMemberInCluster(Entity e) {
             return Optional.fromNullable(e.getAttribute(CouchbaseNode.IS_IN_CLUSTER)).or(false);
         }
         
    +    public void createBuckets() {
    +        //FIXME: multiple buckets require synchronization/wait time (checks for port
conflicts and exceeding ram size)
    --- End diff --
    
    My personal rule of thumb is a `FIXME` is something that should be fixed before merged;
a `TODO` is a suggestion of something that should be done in the future.
    It looks like you've added synchronization. Should this comment be about doing it in a
different way?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message