brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Couchbase sync gateway
Date Tue, 08 Jul 2014 16:31:19 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/25#discussion_r14663634
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseClusterImpl.java
---
    @@ -24,23 +26,36 @@
     import brooklyn.event.AttributeSensor;
     import brooklyn.event.SensorEvent;
     import brooklyn.event.SensorEventListener;
    +import brooklyn.event.basic.DependentConfiguration;
    +import brooklyn.event.feed.http.HttpFeed;
    +import brooklyn.event.feed.http.HttpPollConfig;
    +import brooklyn.event.feed.http.HttpValueFunctions;
    +import brooklyn.event.feed.http.JsonFunctions;
     import brooklyn.location.Location;
     import brooklyn.policy.PolicySpec;
     import brooklyn.util.collections.MutableSet;
    +import brooklyn.util.guava.Functionals;
    +import brooklyn.util.task.DynamicTasks;
    +import brooklyn.util.task.TaskBuilder;
     import brooklyn.util.task.Tasks;
     import brooklyn.util.text.ByteSizeStrings;
    +import brooklyn.util.text.Strings;
     import brooklyn.util.time.Time;
     
     import com.google.common.base.Function;
     import com.google.common.base.Optional;
     import com.google.common.base.Preconditions;
    +import com.google.common.base.Predicates;
     import com.google.common.collect.ImmutableMap;
     import com.google.common.collect.Lists;
     import com.google.common.collect.Sets;
    +import com.google.gson.JsonArray;
    +import com.google.gson.JsonElement;
     
     public class CouchbaseClusterImpl extends DynamicClusterImpl implements CouchbaseCluster
{
         private static final Logger log = LoggerFactory.getLogger(CouchbaseClusterImpl.class);
         private final Object mutex = new Object[0];
    +    private final HttpFeed[] resetBucketCreation = new HttpFeed[]{null};
    --- End diff --
    
    Why an array of size one? It looks like you're using it like an `AtomicReference<HttpFeed>`
with get/set calls.
    
    This field deserves a few lines of comments for what it's for - presumably it's allowing
one to tell when the bucket creation has completed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message