brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix group on member unmanaged
Date Thu, 03 Jul 2014 09:23:32 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/24#discussion_r14504328
  
    --- Diff: api/src/main/java/brooklyn/entity/Entity.java ---
    @@ -135,11 +135,24 @@
         Collection<Group> getGroups();
     
         /**
    -     * Add this entity as a member of the given {@link Group}.
    +     * Add this entity as a member of the given {@link Group}. Called by framework.
    +     * <p>
    +     * Users should call {@link Group#addMember(Entity)} instead; this method will then

    --- End diff --
    
    If this is the case maybe method should move to `EntityInternal` ?  But not in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message