brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [WIP] Skip UNIX-specific tests so...
Date Wed, 25 Jun 2014 13:06:49 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/17

    [WIP] Skip UNIX-specific tests so they don't break Windows builds.

    This PR is meant for discussion rather than merging straight away.
    
    Some of the existing tests are clearly UNIX specific. I have created a new test group
for them and excluded it explicitly from the tests.
    Should I
      * move the tests to the Integration group
      * Find a way to decide at runtime whether the test should be executed based on the current
platform
      * or make them pass on windows as well

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn platform-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 12c35fbeb18099259d3bff0db1af9b70cbf10370
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2014-06-25T12:52:51Z

    Skip UNIX-specific tests so all tests pass on Windows.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message