brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: More windows compatibility change...
Date Mon, 30 Jun 2014 21:04:20 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/29#discussion_r14375503
  
    --- Diff: core/src/main/java/brooklyn/location/basic/LocationConfigKeys.java ---
    @@ -36,7 +38,8 @@
         public static final ConfigKey<String> PASSWORD = ConfigKeys.newStringConfigKey("password");
         public static final ConfigKey<String> PUBLIC_KEY_FILE = ConfigKeys.newStringConfigKey("publicKeyFile",
"colon-separated list of ssh public key file(s) to use; if blank will infer from privateKeyFile
by appending \".pub\"");
         public static final ConfigKey<String> PUBLIC_KEY_DATA = ConfigKeys.newStringConfigKey("publicKeyData",
"ssh public key string to use (takes precedence over publicKeyFile)");
    -    public static final ConfigKey<String> PRIVATE_KEY_FILE = ConfigKeys.newStringConfigKey("privateKeyFile",
"colon-separated list of ssh private key files; uses first in list that can be read", "~/.ssh/id_rsa:~/.ssh/id_dsa");
    +    public static final ConfigKey<String> PRIVATE_KEY_FILE = ConfigKeys.newStringConfigKey("privateKeyFile",
"colon-separated list of ssh private key files; uses first in list that can be read",
    --- End diff --
    
    The description says colon-separated, but on windows it is ";" separated for the default
value.
    
    Where is this value used, to split apart the two paths? I just had a very quick look and
couldn't find it. Does that code need updated as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message