brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [WIP] Skip UNIX-specific tests so...
Date Mon, 30 Jun 2014 10:12:13 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/17#discussion_r14343245
  
    --- Diff: software/base/src/test/java/brooklyn/entity/java/JavaOptsTest.java ---
    @@ -129,7 +129,7 @@ public void tearDown() throws Exception {
             RecordingSshTool.execScriptCmds.clear();
         }
         
    -    @Test
    +    @Test(groups="UNIX")
    --- End diff --
    
    With use of RecordingSshTool, we shouldn't be executing any of these commands I thought;
where does it fail?
    If brooklyn sees that the target location is an ssh'able machine (rather than Windows)
then presumably these commands will match whether executed from windows or linux?
    If the problem is that we're using localhost, then can we change setUp to pass in an ssh'able
machine location instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message