brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: HA uses shared timestamp (last mo...
Date Thu, 26 Jun 2014 11:22:31 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/12#discussion_r14235240
  
    --- Diff: core/src/main/java/brooklyn/management/ha/HighAvailabilityManagerImpl.java ---
    @@ -437,17 +486,30 @@ protected void promoteToMaster() {
             managementContext.getRebindManager().start();
         }
     
    +    protected void demoteToStandby() {
    +        if (!running) {
    +            LOG.warn("Ignoring demote-from-master request, as HighAvailabilityManager
is no longer running");
    +            return;
    +        }
    +
    +        nodeState = ManagementNodeState.STANDBY;
    +        managementContext.getRebindManager().stop();
    +        for (Application app: managementContext.getApplications())
    +            Entities.unmanage(app);
    --- End diff --
    
    Medium term, I'd like to review code for all our entities to ensure that on unmanage they
really do stop all their work (and don't have their own thread kicking around or whatever).
Also would need to think about what happens to effectors currently executing.
    
    But this is good enough for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message