brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fixes the "RetryOnRenew" lease-re...
Date Thu, 26 Jun 2014 10:26:47 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/19#discussion_r14233806
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/entity/rebind/persister/jclouds/JcloudsBlobStoreBasedObjectStore.java
---
    @@ -72,11 +71,7 @@ public synchronized BlobStoreContext getBlobStoreContext() {
                 String provider = checkNotNull(location.getConfig(LocationConfigKeys.CLOUD_PROVIDER),
"provider must not be null");
                 String endpoint = location.getConfig(CloudLocationConfig.CLOUD_ENDPOINT);
     
    -            ContextBuilder contextBuilder = ContextBuilder.newBuilder(provider).credentials(identity,
credential);
    -            if (!Strings.isBlank(endpoint)) {
    -                contextBuilder.endpoint(endpoint);
    -            }
    -            context = contextBuilder.buildView(BlobStoreContext.class);
    +            context = JcloudsUtil.newBlobstoreContext(provider, endpoint, identity, credential,
true);
    --- End diff --
    
    `useSoftlayerFix` should only affect openstack.  the guice `bindInterceptor` is targetted
against an openstack class.  i think there is a good chance this bug will affect some other
openstacks (report of same problem in hp cloud, for instance).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message