brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support for non-UK locales.
Date Wed, 25 Jun 2014 15:18:57 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/16#issuecomment-47115897
  
    Looks good. Not sure about best pattern for tests - doing `extends FixedLocaleTest` feels
like it might well be missed by future people adding new test classes. But I don't really
have a better suggestion. We could register an `ITestListener` to set the locale (e.g. see
`test-support/src/main/java/brooklyn/test/BrooklynLeakListener.java`) but I don't think the
IDE respects that so prefer your approach.
    
    Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message