brooklyn-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbou...@apache.org
Subject [6/8] brooklyn-ui git commit: Revert "Delegate pax-web-spi version to dependencyManagement in parent pom"
Date Thu, 11 Oct 2018 07:54:48 GMT
Revert "Delegate pax-web-spi version to dependencyManagement in parent pom"

This reverts commit c5692a2ec5c0bb0409e0369776556e3794b09f5a.

When building the base brooklyn project, i.e. that which contains
brooklyn-server and brooklyn-ui as submodules, then the maven project fails
validation. This is because the brooklyn-ui project doesn't include a
relativePath element pointing to the pom inside the brookly-server project.

A note in the brooklyn-ui pom explains why there should not be a relativePath
element to it's sibling (../brooklyn-server). Thus the maven reactor for
brooklyn-ui uses whatever brooklyn-parent is available in the reactor path (i.e.
~/.m2/repository, or maven central, etc). I will not use the 'current'
development copy in ../brooklyn-server/parent.


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-ui/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-ui/commit/0d727d0d
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-ui/tree/0d727d0d
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-ui/diff/0d727d0d

Branch: refs/heads/master
Commit: 0d727d0d4a1a6c04868d1264549e54e2a279b743
Parents: c5692a2
Author: Paul Campbell <paul.campbell@cloudsoft.io>
Authored: Sat Sep 29 11:48:47 2018 +0100
Committer: Paul Campbell <paul.campbell@cloudsoft.io>
Committed: Sat Sep 29 11:48:47 2018 +0100

----------------------------------------------------------------------
 modularity-server/module-api/pom.xml | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-ui/blob/0d727d0d/modularity-server/module-api/pom.xml
----------------------------------------------------------------------
diff --git a/modularity-server/module-api/pom.xml b/modularity-server/module-api/pom.xml
index b6ebd5a..60fadb3 100644
--- a/modularity-server/module-api/pom.xml
+++ b/modularity-server/module-api/pom.xml
@@ -72,6 +72,7 @@
         <dependency>
             <groupId>org.ops4j.pax.web</groupId>
             <artifactId>pax-web-spi</artifactId>
+            <version>${pax-web.version}</version>  <!-- as it's provided we
just need compile support; runtime is pulled in by karaf -->
             <scope>provided</scope>
         </dependency>
 


Mime
View raw message