Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1D128200CF3 for ; Wed, 13 Sep 2017 13:49:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1B9E91609C9; Wed, 13 Sep 2017 11:49:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 380081609CA for ; Wed, 13 Sep 2017 13:49:02 +0200 (CEST) Received: (qmail 85941 invoked by uid 500); 13 Sep 2017 11:49:01 -0000 Mailing-List: contact commits-help@brooklyn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.apache.org Delivered-To: mailing list commits@brooklyn.apache.org Received: (qmail 85892 invoked by uid 99); 13 Sep 2017 11:49:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Sep 2017 11:49:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D1A28F5738; Wed, 13 Sep 2017 11:48:59 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: drigodwin@apache.org To: commits@brooklyn.apache.org Date: Wed, 13 Sep 2017 11:49:00 -0000 Message-Id: In-Reply-To: <1b6b3ee254b14630841f5d6e75a17693@git.apache.org> References: <1b6b3ee254b14630841f5d6e75a17693@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/3] brooklyn-server git commit: better preserve backwards compat (fixing tests) and tidy warnings/comments archived-at: Wed, 13 Sep 2017 11:49:03 -0000 better preserve backwards compat (fixing tests) and tidy warnings/comments Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/4a4dd092 Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/4a4dd092 Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/4a4dd092 Branch: refs/heads/master Commit: 4a4dd092f5a63946bf05f624f878b09defa392ef Parents: 6a8800d Author: Alex Heneveld Authored: Mon Sep 11 14:15:29 2017 +0100 Committer: Alex Heneveld Committed: Mon Sep 11 14:15:29 2017 +0100 ---------------------------------------------------------------------- .../apache/brooklyn/core/BrooklynVersion.java | 38 ++++++++++++++------ .../catalog/internal/BasicBrooklynCatalog.java | 14 ++++++-- .../core/typereg/BasicBrooklynTypeRegistry.java | 10 ++++-- 3 files changed, 48 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/4a4dd092/core/src/main/java/org/apache/brooklyn/core/BrooklynVersion.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/brooklyn/core/BrooklynVersion.java b/core/src/main/java/org/apache/brooklyn/core/BrooklynVersion.java index 4cc1352..fa64665 100644 --- a/core/src/main/java/org/apache/brooklyn/core/BrooklynVersion.java +++ b/core/src/main/java/org/apache/brooklyn/core/BrooklynVersion.java @@ -29,6 +29,7 @@ import java.util.Hashtable; import java.util.List; import java.util.Map; import java.util.Properties; +import java.util.Set; import java.util.concurrent.atomic.AtomicReference; import java.util.jar.Attributes; @@ -36,11 +37,15 @@ import javax.annotation.Nullable; import org.apache.brooklyn.api.catalog.CatalogItem; import org.apache.brooklyn.api.mgmt.ManagementContext; +import org.apache.brooklyn.api.typereg.ManagedBundle; +import org.apache.brooklyn.api.typereg.OsgiBundleWithUrl; +import org.apache.brooklyn.api.typereg.RegisteredType; import org.apache.brooklyn.core.catalog.internal.BasicBrooklynCatalog; import org.apache.brooklyn.core.mgmt.classloading.OsgiBrooklynClassLoadingContext; import org.apache.brooklyn.core.mgmt.ha.OsgiManager; import org.apache.brooklyn.core.mgmt.internal.ManagementContextInternal; import org.apache.brooklyn.rt.felix.ManifestHelper; +import org.apache.brooklyn.util.collections.MutableSet; import org.apache.brooklyn.util.core.ResourceUtils; import org.apache.brooklyn.util.exceptions.Exceptions; import org.apache.brooklyn.util.guava.Maybe; @@ -309,16 +314,22 @@ public class BrooklynVersion implements BrooklynVersionService { ); Maybe osgi = ((ManagementContextInternal)mgmt).getOsgiManager(); - for (CatalogItem catalogItem : mgmt.getCatalog().getCatalogItems()) { - if (osgi.isPresentAndNonNull()) { - for (CatalogItem.CatalogBundle catalogBundle : catalogItem.getLibraries()) { + if (osgi.isPresentAndNonNull()) { + for (ManagedBundle b: osgi.get().getManagedBundles().values()) { + Maybe osgiBundle = osgi.get().findBundle(b); + if (osgiBundle.isPresentAndNonNull()) { + bundles.add(osgiBundle.get()); + } + } + // TODO remove when everything uses osgi bundles tracked by brooklyn above + for (RegisteredType t: mgmt.getTypeRegistry().getAll()) { + for (OsgiBundleWithUrl catalogBundle : t.getLibraries()) { Maybe osgiBundle = osgi.get().findBundle(catalogBundle); if (osgiBundle.isPresentAndNonNull()) { bundles.add(osgiBundle.get()); } } } - } // Set over list in case a bundle is reported more than once (e.g. from classpath and from OSGi). @@ -332,14 +343,21 @@ public class BrooklynVersion implements BrooklynVersionService { } return features.build(); } else { - Iterable manifests = ResourceUtils.create(mgmt).getResources(MANIFEST_PATH); + Set manifests = MutableSet.copyOf(ResourceUtils.create(mgmt).getResources(MANIFEST_PATH)); - for (CatalogItem catalogItem : mgmt.getCatalog().getCatalogItems()) { - OsgiBrooklynClassLoadingContext osgiContext = new OsgiBrooklynClassLoadingContext( - mgmt, catalogItem.getCatalogItemId(), catalogItem.getLibraries()); - manifests = Iterables.concat(manifests, osgiContext.getResources(MANIFEST_PATH)); + Maybe osgi = ((ManagementContextInternal)mgmt).getOsgiManager(); + if (osgi.isPresentAndNonNull()) { + // get manifests for all bundles installed + Iterables.addAll(manifests, + osgi.get().getResources(MANIFEST_PATH, osgi.get().getManagedBundles().values()) ); } - + + // TODO remove when everything uses osgi bundles tracked by brooklyn above + for (RegisteredType t: mgmt.getTypeRegistry().getAll()) { + OsgiBrooklynClassLoadingContext osgiContext = new OsgiBrooklynClassLoadingContext(mgmt, t.getId(), t.getLibraries()); + Iterables.addAll(manifests, osgiContext.getResources(MANIFEST_PATH)); + } + // Set over list in case a bundle is reported more than once (e.g. from classpath and from OSGi). // Not sure of validity of this approach over just reporting duplicates. ImmutableSet.Builder features = ImmutableSet.builder(); http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/4a4dd092/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java b/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java index 3177a50..d170970 100644 --- a/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java +++ b/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java @@ -348,13 +348,19 @@ public class BasicBrooklynCatalog implements BrooklynCatalog { @SuppressWarnings({ "unchecked", "rawtypes" }) @Override public CatalogItem getCatalogItem(Class type, String id, String version) { + CatalogItem item = (CatalogItem) getCatalogItemLegacy(type, id, version); + if (item!=null) { + return item; + } + RegisteredType rt = mgmt.getTypeRegistry().get(id, version); if (rt!=null) { if (rt.getSuperTypes().contains(type) || rt.getSuperTypes().contains(type.getName())) { return (CatalogItem) RegisteredTypes.toPartialCatalogItem(rt); } } - return getCatalogItemLegacy(type, id, version); + + return null; } @SuppressWarnings("unchecked") @@ -1805,10 +1811,14 @@ public class BasicBrooklynCatalog implements BrooklynCatalog { log.debug("Forcing catalog load on access of catalog items"); load(); } - result.putAll((Map)catalog.getIdCache()); for (RegisteredType rt: mgmt.getTypeRegistry().getAll()) { result.put(rt.getId(), (CatalogItem)RegisteredTypes.toPartialCatalogItem(rt)); } + // prefer locally registered items in this method; prevents conversion to and from RT; + // possibly allows different views if there are diff items in catlaog and type registry + // but this means at least it is consistent for user if they are consistent; + // and can easily live with this until catalog is entirely replaced to TR + result.putAll((Map)catalog.getIdCache()); return result.values(); } http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/4a4dd092/core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java b/core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java index 440d301..983403c 100644 --- a/core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java +++ b/core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java @@ -96,8 +96,14 @@ public class BasicBrooklynTypeRegistry implements BrooklynTypeRegistry { Iterables.transform(mgmt.getCatalog().getCatalogItemsLegacy(), RegisteredTypes.CI_TO_RT), filter)) { if (!result.containsKey(rt.getId())) { - // shouldn't be using this now - log.warn("Item '"+rt.getId()+"' not in type registry; only found in legacy catalog"); + // TODO ideally never come here, however + // legacy cataog currently still used for java-scanned annotations; + // hopefully that will be deprecated and removed in near future + // (probably after switch to osgi and using catalog.bom -- + // though it would not be too hard for java scan code in CatalogClasspath.load to + // make TypeRegistry instances instead of CatalogItem, esp if we had YOML to write that plan) + + //log.warn("Item '"+rt.getId()+"' not in type registry; only found in legacy catalog"); result.put(rt.getId(), rt); } }