Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 76BC3200CF3 for ; Wed, 13 Sep 2017 17:51:30 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 756AC1609C9; Wed, 13 Sep 2017 15:51:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B86141609CA for ; Wed, 13 Sep 2017 17:51:29 +0200 (CEST) Received: (qmail 98942 invoked by uid 500); 13 Sep 2017 15:51:27 -0000 Mailing-List: contact commits-help@brooklyn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.apache.org Delivered-To: mailing list commits@brooklyn.apache.org Received: (qmail 98870 invoked by uid 99); 13 Sep 2017 15:51:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Sep 2017 15:51:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D0255F57DC; Wed, 13 Sep 2017 15:51:26 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: heneveld@apache.org To: commits@brooklyn.apache.org Date: Wed, 13 Sep 2017 15:51:27 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/3] brooklyn-server git commit: only search in legacy catalog items in a couple other places archived-at: Wed, 13 Sep 2017 15:51:30 -0000 only search in legacy catalog items in a couple other places and disable by default a feature that searches in all catalog bundles when rebinding (as persistence should now include bundles) Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/cc597770 Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/cc597770 Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/cc597770 Branch: refs/heads/master Commit: cc597770823a4c8dbe659eaed1e310bfe90dd0a5 Parents: 1941021 Author: Alex Heneveld Authored: Wed Sep 13 16:39:04 2017 +0100 Committer: Alex Heneveld Committed: Wed Sep 13 16:39:04 2017 +0100 ---------------------------------------------------------------------- .../org/apache/brooklyn/core/BrooklynFeatureEnablement.java | 2 +- .../brooklyn/core/mgmt/persist/BrooklynPersistenceUtils.java | 2 +- .../org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/cc597770/core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java b/core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java index 8bbe2a4..55d6af0 100644 --- a/core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java +++ b/core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java @@ -146,7 +146,7 @@ public class BrooklynFeatureEnablement { setDefault(FEATURE_DEFAULT_STANDBY_IS_HOT_PROPERTY, false); setDefault(FEATURE_RENAME_THREADS, false); setDefault(FEATURE_JITTER_THREADS, false); - setDefault(FEATURE_BACKWARDS_COMPATIBILITY_INFER_CATALOG_ITEM_ON_REBIND, true); + setDefault(FEATURE_BACKWARDS_COMPATIBILITY_INFER_CATALOG_ITEM_ON_REBIND, false); setDefault(FEATURE_AUTO_FIX_CATALOG_REF_ON_REBIND, false); setDefault(FEATURE_SSH_ASYNC_EXEC, false); setDefault(FEATURE_VALIDATE_LOCATION_SSH_KEYS, true); http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/cc597770/core/src/main/java/org/apache/brooklyn/core/mgmt/persist/BrooklynPersistenceUtils.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/brooklyn/core/mgmt/persist/BrooklynPersistenceUtils.java b/core/src/main/java/org/apache/brooklyn/core/mgmt/persist/BrooklynPersistenceUtils.java index ca63cce..4c424b4 100644 --- a/core/src/main/java/org/apache/brooklyn/core/mgmt/persist/BrooklynPersistenceUtils.java +++ b/core/src/main/java/org/apache/brooklyn/core/mgmt/persist/BrooklynPersistenceUtils.java @@ -189,7 +189,7 @@ public class BrooklynPersistenceUtils { result.policy(instanceAdjunct.getId(), serializer.toString(newObjectMemento(instanceAdjunct))); } } - for (CatalogItem instance: mgmt.getCatalog().getCatalogItems()) { + for (CatalogItem instance: mgmt.getCatalog().getCatalogItemsLegacy()) { result.catalogItem(instance.getId(), serializer.toString(newObjectMemento(instance))); } OsgiManager osgi = ((LocalManagementContext)mgmt).getOsgiManager().orNull(); http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/cc597770/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java b/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java index 76a4d31..36f4275 100644 --- a/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java +++ b/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java @@ -1122,12 +1122,13 @@ public abstract class RebindIteration { throw new IllegalStateException("Unable to load "+jType+" for catalog item " + catalogItemId + " for " + contextSuchAsId); } else if (BrooklynFeatureEnablement.isEnabled(FEATURE_BACKWARDS_COMPATIBILITY_INFER_CATALOG_ITEM_ON_REBIND)) { - //Try loading from whichever catalog bundle succeeds. + //Try loading from whichever catalog bundle succeeds (legacy CI items only; also disabling this, as no longer needed 2017-09) BrooklynCatalog catalog = managementContext.getCatalog(); - for (CatalogItem item : catalog.getCatalogItems()) { + for (CatalogItem item : catalog.getCatalogItemsLegacy()) { BrooklynClassLoadingContext catalogLoader = CatalogUtils.newClassLoadingContext(managementContext, item); Maybe> catalogClass = catalogLoader.tryLoadClass(jType); if (catalogClass.isPresent()) { + LOG.warn("Found "+jType+" only by scanning catalog item search paths"); return new LoadedClass((Class) catalogClass.get(), catalogItemId, reboundSearchPath); } }