brooklyn-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [4/4] brooklyn-server git commit: Closes #530
Date Thu, 26 Jan 2017 09:43:46 GMT
Closes #530

JcloudsLocation is not releasing its customizers (BROOKLYN-427)

preRelease and postRelease of JcloudsLocationCustomizers are not being
called as expected during the release of a Jclouds machine location.
The problem is that the "setup" used in JcloudsLocation.obtainOnce includes a copy of the
flags passed from MachineLifecycleEffectorTasks#stopAnyProvisionedMachines,
which includes the customizers. However, the "setup" used in the "release"
method of JcloudsLocation is taken from the JcloudsLocation itself, which
is the provisioning (i.e. parent) location, which doesn't have those
customizers in it.
It would actually make more sense to get the location customizers from
the machine location, as a given parent could have mutiple machines
with different customizers.

The changes here include an addition to the
`JcloudsCustomizerInstantiationYamlDslTest#testCustomizers`
to demonstrate the problem, and a fix that adds the config to
the machine location.


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/2c052ada
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/2c052ada
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/2c052ada

Branch: refs/heads/master
Commit: 2c052ada06122e9ad5626615bd2bc75ab6c8e4a8
Parents: 4efb16f 645d59b
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Authored: Thu Jan 26 11:43:29 2017 +0200
Committer: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Committed: Thu Jan 26 11:43:29 2017 +0200

----------------------------------------------------------------------
 ...loudsCustomizerInstantiationYamlDslTest.java | 33 +++++++++---
 .../location/jclouds/JcloudsLocation.java       | 57 +++++++++++++-------
 2 files changed, 64 insertions(+), 26 deletions(-)
----------------------------------------------------------------------



Mime
View raw message