brooklyn-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From henev...@apache.org
Subject [6/9] brooklyn-library git commit: comments in conf file as per PR
Date Wed, 31 Aug 2016 00:04:39 GMT
comments in conf file as per PR


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/d2ac9d7e
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/d2ac9d7e
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/d2ac9d7e

Branch: refs/heads/master
Commit: d2ac9d7e16eaf08c8878fc4c6806dba0e7038a3c
Parents: bbdda16
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Authored: Mon Aug 29 12:42:00 2016 +0100
Committer: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Committed: Mon Aug 29 12:42:00 2016 +0100

----------------------------------------------------------------------
 .../org/apache/brooklyn/entity/network/bind/named.conf        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/d2ac9d7e/software/network/src/main/resources/org/apache/brooklyn/entity/network/bind/named.conf
----------------------------------------------------------------------
diff --git a/software/network/src/main/resources/org/apache/brooklyn/entity/network/bind/named.conf
b/software/network/src/main/resources/org/apache/brooklyn/entity/network/bind/named.conf
index 99d1682..98efdd6 100644
--- a/software/network/src/main/resources/org/apache/brooklyn/entity/network/bind/named.conf
+++ b/software/network/src/main/resources/org/apache/brooklyn/entity/network/bind/named.conf
@@ -20,9 +20,14 @@
 // Generated by Brooklyn on ${.now?string.short}
 //
 options {
-    // listen-on default is all interfaces
+    // listen-on default is all interfaces -- but we should include with the word 'any' to
get the port
     // listen-on port ${entity.dnsPort} { 127.0.0.1; ${driver.address}; ${driver.subnetAddress};
};
+    // i think this will only do loopback for ipv6 so should change
     listen-on-v6 port ${entity.dnsPort} { ::1; };
+    // the following is suggested instead, and @grkvlt notes it will apply to all interfaces
even ipv4
+    // so in theory that's all we need, but it does need testing
+    // listen-on-v6 ${entity.dnsPort} { any; };
+    // TODO ^^^
     directory "${driver.osSupport.configDirectory}";
     dump-file "${driver.dataDirectory}/cache_dump.db";
     statistics-file "${driver.dataDirectory}/named_stats.txt";


Mime
View raw message