brooklyn-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [1/2] brooklyn-server git commit: BROOKLYN-272: disable failing non-deterministic tests
Date Wed, 25 May 2016 07:33:08 GMT
Repository: brooklyn-server
Updated Branches:
  refs/heads/master 3853dfce3 -> 9c216e410


BROOKLYN-272: disable failing non-deterministic tests


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/fe8a2f87
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/fe8a2f87
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/fe8a2f87

Branch: refs/heads/master
Commit: fe8a2f87168f1424b244bc7bf5ad40e37fd44f5d
Parents: 3853dfc
Author: Aled Sage <aled.sage@gmail.com>
Authored: Fri May 20 12:21:25 2016 +0100
Committer: Aled Sage <aled.sage@gmail.com>
Committed: Tue May 24 18:28:41 2016 +0100

----------------------------------------------------------------------
 .../org/apache/brooklyn/core/feed/PollerTest.java    | 15 ++++++++++++++-
 .../brooklyn/entity/stock/BasicStartableTest.java    |  8 +++++++-
 .../LoadBalancingPolicyConcurrencyTest.java          | 14 +++++++++++++-
 3 files changed, 34 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/fe8a2f87/core/src/test/java/org/apache/brooklyn/core/feed/PollerTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/apache/brooklyn/core/feed/PollerTest.java b/core/src/test/java/org/apache/brooklyn/core/feed/PollerTest.java
index 6495f566..9dde21a 100644
--- a/core/src/test/java/org/apache/brooklyn/core/feed/PollerTest.java
+++ b/core/src/test/java/org/apache/brooklyn/core/feed/PollerTest.java
@@ -54,7 +54,20 @@ public class PollerTest extends BrooklynAppUnitTestSupport {
         return new Object[][]{{pollFailer}, {taskFailer}};
     }
 
-    @Test(dataProvider = "specProvider")
+    // TODO BROOKLYN-272, Disabled, because fails non-deterministically in jenkins (windows):
+    //    testFeedContinuesWhenPollerThrows(org.apache.brooklyn.core.feed.PollerTest)  Time
elapsed: 3.556 sec  <<< FAILURE!
+    //    org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: failed succeeds-eventually,
4 attempts, 105ms elapsed: AssertionError: entity=FeedExceptionEntityImpl{id=dYG0SKbP}; attribute=Sensor:
flag (java.lang.Boolean) expected [false] but found [true]
+    //        at org.apache.brooklyn.test.Asserts.fail(Asserts.java:721)
+    //        at org.apache.brooklyn.test.Asserts.failNotEquals(Asserts.java:114)
+    //        at org.apache.brooklyn.test.Asserts.assertEquals(Asserts.java:436)
+    //        at org.apache.brooklyn.core.entity.EntityAsserts.assertAttributeEquals(EntityAsserts.java:54)
+    //        at org.apache.brooklyn.core.entity.EntityAsserts$1.run(EntityAsserts.java:70)
+    //        at org.apache.brooklyn.test.Asserts$RunnableAdapter.call(Asserts.java:1277)
+    //        at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:930)
+    //        at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:854)
+    //        at org.apache.brooklyn.core.entity.EntityAsserts.assertAttributeEqualsEventually(EntityAsserts.java:67)
+    //        at org.apache.brooklyn.core.feed.PollerTest.testFeedContinuesWhenPollerThrows(PollerTest.java:65)
+    @Test(dataProvider = "specProvider", groups={"Broken"})
     public void testFeedContinuesWhenPollerThrows(EntitySpec<FeedExceptionEntity> spec)
{
         Map<?, ?> timeoutFlags = ImmutableMap.of("timeout", "100ms");
         FeedExceptionEntity fee = app.createAndManageChild(spec);

http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/fe8a2f87/core/src/test/java/org/apache/brooklyn/entity/stock/BasicStartableTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/apache/brooklyn/entity/stock/BasicStartableTest.java b/core/src/test/java/org/apache/brooklyn/entity/stock/BasicStartableTest.java
index 227dbeb..d943468 100644
--- a/core/src/test/java/org/apache/brooklyn/entity/stock/BasicStartableTest.java
+++ b/core/src/test/java/org/apache/brooklyn/entity/stock/BasicStartableTest.java
@@ -149,7 +149,13 @@ public class BasicStartableTest {
         assertNull(called.get());
     }
 
-    @Test
+    // TODO BROOKLYN-272, Disabled, because fails non-deterministically in jenkins: BROOKLYN-256
+    //    java.lang.AssertionError: Expected: eventually IsEqualTo([starting, running, stopping,
stopped]); got most recently: [starting, running, starting, running, stopping, stopped] (waited
1s 11ms 498us 762ns, checked 100)
+    //        at org.apache.brooklyn.test.Asserts.fail(Asserts.java:721)
+    //        at org.apache.brooklyn.test.Asserts.eventually(Asserts.java:791)
+    //        at org.apache.brooklyn.test.Asserts.eventually(Asserts.java:751)
+    //        at org.apache.brooklyn.entity.stock.BasicStartableTest.testTransitionsThroughLifecycles(BasicStartableTest.java:170)
+    @Test(groups={"Broken"})
     public void testTransitionsThroughLifecycles() throws Exception {
         startable = app.addChild(EntitySpec.create(BasicStartable.class));
         EntityAsserts.assertAttributeEqualsEventually(app, Attributes.SERVICE_STATE_ACTUAL,
Lifecycle.STOPPED);

http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/fe8a2f87/policy/src/test/java/org/apache/brooklyn/policy/loadbalancing/LoadBalancingPolicyConcurrencyTest.java
----------------------------------------------------------------------
diff --git a/policy/src/test/java/org/apache/brooklyn/policy/loadbalancing/LoadBalancingPolicyConcurrencyTest.java
b/policy/src/test/java/org/apache/brooklyn/policy/loadbalancing/LoadBalancingPolicyConcurrencyTest.java
index f5b45ad..02dc85f 100644
--- a/policy/src/test/java/org/apache/brooklyn/policy/loadbalancing/LoadBalancingPolicyConcurrencyTest.java
+++ b/policy/src/test/java/org/apache/brooklyn/policy/loadbalancing/LoadBalancingPolicyConcurrencyTest.java
@@ -79,7 +79,19 @@ public class LoadBalancingPolicyConcurrencyTest extends AbstractLoadBalancingPol
         assertWorkratesEventually(containers, items, Collections.nCopies(NUM_CONTAINERS,
20d), WORKRATE_JITTER);
     }
     
-    @Test
+    // TODO BROOKLYN-272, Disabled, because fails non-deterministically in jenkins:
+    //    org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: failed succeeds-eventually,
29 attempts, 10002ms elapsed: AssertionError: actual=[18.0, 21.0, 19.0, 0.0, 20.0, 0.0, 20.0,
36.0, 19.0, 0.0, 19.0, 21.0, 21.0, 19.0, 21.0, 36.0, 21.0, 19.0, 18.0, 36.0]; expected=[20.0,
20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0, 20.0,
20.0, 20.0, 20.0, 20.0] expected [20.0] but found [0.0]
+    //            at org.testng.Assert.fail(Assert.java:94)
+    //            at org.testng.Assert.failNotEquals(Assert.java:494)
+    //            at org.testng.Assert.assertEquals(Assert.java:207)
+    //            at org.apache.brooklyn.policy.loadbalancing.AbstractLoadBalancingPolicyTest.assertWorkrates(AbstractLoadBalancingPolicyTest.java:122)
+    //            at org.apache.brooklyn.policy.loadbalancing.AbstractLoadBalancingPolicyTest$2.run(AbstractLoadBalancingPolicyTest.java:138)
+    //            at org.apache.brooklyn.test.Asserts$RunnableAdapter.call(Asserts.java:1277)
+    //            at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:930)
+    //            at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:854)
+    //            at org.apache.brooklyn.policy.loadbalancing.AbstractLoadBalancingPolicyTest.assertWorkratesEventually(AbstractLoadBalancingPolicyTest.java:136)
+    //            at org.apache.brooklyn.policy.loadbalancing.LoadBalancingPolicyConcurrencyTest.testConcurrentlyAddContainers(LoadBalancingPolicyConcurrencyTest.java:101)
+    @Test(groups={"Broken"})
     public void testConcurrentlyAddContainers() {
         final Queue<MockContainerEntity> containers = new ConcurrentLinkedQueue<MockContainerEntity>();
         final List<MockItemEntity> items = Lists.newArrayList();


Mime
View raw message