brooklyn-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From henev...@apache.org
Subject [13/13] brooklyn-library git commit: tidy review comments for riak node driver
Date Mon, 07 Mar 2016 09:32:43 GMT
tidy review comments for riak node driver


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/a0e352de
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/a0e352de
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/a0e352de

Branch: refs/heads/master
Commit: a0e352de176756dfede7f6ae7e69c4c78a88b36e
Parents: 632ff60
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Authored: Mon Mar 7 09:26:37 2016 +0000
Committer: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Committed: Mon Mar 7 09:26:37 2016 +0000

----------------------------------------------------------------------
 .../apache/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java   | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/a0e352de/software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
----------------------------------------------------------------------
diff --git a/software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
b/software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
index 00b675e..a62b400 100644
--- a/software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
+++ b/software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java
@@ -108,11 +108,6 @@ public class RiakNodeSshDriver extends JavaSoftwareProcessSshDriver implements
R
 
     @Override
     public void install() {
-        // TODO download URL can be inferred
-//        if (entity.getConfig(Attributes.DOWNLOAD_URL) != null) {
-//            LOG.warn("Ignoring download.url {}, use download.url.rhelcentos or download.url.mac",
entity.getConfig(Attributes.DOWNLOAD_URL));
-//        }
-
         OsDetails osDetails = getMachine().getMachineDetails().getOsDetails();
         List<String> commands = Lists.newLinkedList();
         if (osDetails.isLinux()) {
@@ -130,6 +125,7 @@ public class RiakNodeSshDriver extends JavaSoftwareProcessSshDriver implements
R
                     getMachine() + ". Details: " + getMachine().getMachineDetails().getOsDetails());
         }
 
+        LOG.debug("Installing to "+this+" using commands:\n"+Strings.join(commands, "\n"));
         int result = newScript(INSTALLING)
                 .body.append(commands)
                 .failIfBodyEmpty()


Mime
View raw message