Return-Path: X-Original-To: apmail-brooklyn-commits-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C26C18CD7 for ; Tue, 17 Nov 2015 18:28:47 +0000 (UTC) Received: (qmail 74170 invoked by uid 500); 17 Nov 2015 18:28:47 -0000 Delivered-To: apmail-brooklyn-commits-archive@brooklyn.apache.org Received: (qmail 74148 invoked by uid 500); 17 Nov 2015 18:28:47 -0000 Mailing-List: contact commits-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list commits@brooklyn.incubator.apache.org Received: (qmail 74139 invoked by uid 99); 17 Nov 2015 18:28:46 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 18:28:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 69258180041 for ; Tue, 17 Nov 2015 18:28:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.77 X-Spam-Level: * X-Spam-Status: No, score=1.77 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id XhoXV2o96AL1 for ; Tue, 17 Nov 2015 18:28:45 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 7EDE622F0D for ; Tue, 17 Nov 2015 18:28:45 +0000 (UTC) Received: (qmail 74078 invoked by uid 99); 17 Nov 2015 18:28:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 18:28:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 48730E03EC; Tue, 17 Nov 2015 18:28:45 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: aledsage@apache.org To: commits@brooklyn.incubator.apache.org Date: Tue, 17 Nov 2015 18:28:46 -0000 Message-Id: <63ae4074402148c6bd826c2cae4bf91e@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/7] incubator-brooklyn git commit: Fix NetworkingUtilsTest.testIsPortAvailableReportsTrueWhenPortIsFree Fix NetworkingUtilsTest.testIsPortAvailableReportsTrueWhenPortIsFree Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/d192ad04 Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/d192ad04 Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/d192ad04 Branch: refs/heads/master Commit: d192ad04f7903b417d77eb99015eaa9c37a2a1b2 Parents: 3fe1d9d Author: Aled Sage Authored: Thu Nov 5 22:36:17 2015 +0000 Committer: Aled Sage Committed: Tue Nov 17 17:49:26 2015 +0000 ---------------------------------------------------------------------- .../org/apache/brooklyn/util/net/NetworkingUtilsTest.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/d192ad04/utils/common/src/test/java/org/apache/brooklyn/util/net/NetworkingUtilsTest.java ---------------------------------------------------------------------- diff --git a/utils/common/src/test/java/org/apache/brooklyn/util/net/NetworkingUtilsTest.java b/utils/common/src/test/java/org/apache/brooklyn/util/net/NetworkingUtilsTest.java index 788b574..811c712 100644 --- a/utils/common/src/test/java/org/apache/brooklyn/util/net/NetworkingUtilsTest.java +++ b/utils/common/src/test/java/org/apache/brooklyn/util/net/NetworkingUtilsTest.java @@ -100,14 +100,15 @@ public class NetworkingUtilsTest { @Test public void testIsPortAvailableReportsTrueWhenPortIsFree() throws Exception { + final int MIN_FREE = 5; int port = 58769; int numFree = 0; - for (int i = 0; i < 10; i++) { - if (Networking.isPortAvailable(port)) + for (int i = 0; i < 50 && numFree < MIN_FREE; i++) { + if (Networking.isPortAvailable(port+i)) numFree++; } - if (numFree<=5) - fail("This test requires that at least some ports near 58769+ not be in use."); + if (numFree < MIN_FREE) + fail("This test requires that at least some ports near "+port+"+ not be in use."); } @Test