Return-Path: X-Original-To: apmail-brooklyn-commits-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D4B218CDA for ; Tue, 17 Nov 2015 18:28:47 +0000 (UTC) Received: (qmail 74253 invoked by uid 500); 17 Nov 2015 18:28:47 -0000 Delivered-To: apmail-brooklyn-commits-archive@brooklyn.apache.org Received: (qmail 74230 invoked by uid 500); 17 Nov 2015 18:28:47 -0000 Mailing-List: contact commits-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list commits@brooklyn.incubator.apache.org Received: (qmail 74221 invoked by uid 99); 17 Nov 2015 18:28:47 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 18:28:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C9B9A180A18 for ; Tue, 17 Nov 2015 18:28:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.77 X-Spam-Level: * X-Spam-Status: No, score=1.77 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZHuKzmvwNAgy for ; Tue, 17 Nov 2015 18:28:46 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 8F8D62327B for ; Tue, 17 Nov 2015 18:28:45 +0000 (UTC) Received: (qmail 74084 invoked by uid 99); 17 Nov 2015 18:28:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 18:28:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 56FACE0998; Tue, 17 Nov 2015 18:28:45 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: aledsage@apache.org To: commits@brooklyn.incubator.apache.org Date: Tue, 17 Nov 2015 18:28:48 -0000 Message-Id: <34e8bfe186ba4f579b449c882f02b4d2@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [4/7] incubator-brooklyn git commit: Adds TODO question to Networking.isReaachable Adds TODO question to Networking.isReaachable Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/3fe1d9d7 Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/3fe1d9d7 Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/3fe1d9d7 Branch: refs/heads/master Commit: 3fe1d9d758e113fc05a59f7e9fb86f2c14bba5e2 Parents: 4cc09b0 Author: Aled Sage Authored: Mon Nov 9 08:28:56 2015 +0000 Committer: Aled Sage Committed: Tue Nov 17 17:49:26 2015 +0000 ---------------------------------------------------------------------- .../main/java/org/apache/brooklyn/util/net/Networking.java | 7 +++++++ 1 file changed, 7 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/3fe1d9d7/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java ---------------------------------------------------------------------- diff --git a/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java b/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java index 695e3f8..fb988c7 100644 --- a/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java +++ b/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java @@ -26,6 +26,7 @@ import java.net.NetworkInterface; import java.net.ServerSocket; import java.net.Socket; import java.net.SocketException; +import java.net.URI; import java.net.UnknownHostException; import java.util.Arrays; import java.util.Enumeration; @@ -486,6 +487,12 @@ public class Networking { } public static boolean isReachable(HostAndPort endpoint) { + // TODO Should we create an unconnected socket, and then use the calls below (see jclouds' InetSocketAddressConnect): + // socket.setReuseAddress(false); + // socket.setSoLinger(false, 1); + // socket.setSoTimeout(timeout); + // socket.connect(socketAddress, timeout); + try { Socket s = new Socket(endpoint.getHostText(), endpoint.getPort()); closeQuietly(s);