brooklyn-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aleds...@apache.org
Subject [1/8] git commit: Add comment to RebindCatalogEntityTest about failure
Date Wed, 05 Nov 2014 00:21:31 GMT
Repository: incubator-brooklyn
Updated Branches:
  refs/heads/master 00b5a872b -> c398136f7


Add comment to RebindCatalogEntityTest about failure

- Non-deterministic failure seen once on jenkins

Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/1a9636ac
Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/1a9636ac
Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/1a9636ac

Branch: refs/heads/master
Commit: 1a9636ac9e2eec4cfa6486320befe82fe2b0d8ca
Parents: 00b5a87
Author: Aled Sage <aled.sage@gmail.com>
Authored: Tue Nov 4 22:31:17 2014 +0000
Committer: Aled Sage <aled.sage@gmail.com>
Committed: Tue Nov 4 22:31:17 2014 +0000

----------------------------------------------------------------------
 .../java/brooklyn/entity/rebind/RebindCatalogEntityTest.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/1a9636ac/core/src/test/java/brooklyn/entity/rebind/RebindCatalogEntityTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/brooklyn/entity/rebind/RebindCatalogEntityTest.java b/core/src/test/java/brooklyn/entity/rebind/RebindCatalogEntityTest.java
index eac2e35..2e3c621 100644
--- a/core/src/test/java/brooklyn/entity/rebind/RebindCatalogEntityTest.java
+++ b/core/src/test/java/brooklyn/entity/rebind/RebindCatalogEntityTest.java
@@ -42,6 +42,7 @@ import brooklyn.event.basic.Sensors;
 import brooklyn.management.ha.ManagementNodeState;
 import brooklyn.management.internal.LocalManagementContext;
 import brooklyn.util.javalang.UrlClassLoader;
+import brooklyn.util.os.Os;
 
 public class RebindCatalogEntityTest extends RebindTestFixture<StartableApplication>
{
 
@@ -82,10 +83,7 @@ public class RebindCatalogEntityTest extends RebindTestFixture<StartableApplicat
         super.setUp();
     }
 
-    // TODO Fails with an NPE trying to use:
-    //      managementContext.getCatalog().addToClasspath(url.toString())
-    //      classLoader = origManagementContext.getCatalog().getRootClassLoader();
-    //      appClazz = (Class<? extends AbstractApplication>) classLoader.loadClass(APP_CLASSNAME);
+    // TODO Failed in jenkins (once on 20141104, with invocationCount=100): mysensor was
null post-rebind.
     //
     // Note: to test before/after behaviour (i.e. that we're really fixing what we think
we are) then comment out the body of:
     //       AbstractMemento.injectTypeClass(Class)


Mime
View raw message