brooklyn-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aleds...@apache.org
Subject [6/7] git commit: BrooklynLauncherRebindToCloudObjectStoreTest: minor improvement
Date Wed, 15 Oct 2014 14:20:00 GMT
BrooklynLauncherRebindToCloudObjectStoreTest: minor improvement

- FIXME comments about failures seen in jenkins
- mark setUp() as alwaysRun=true


Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/2603a18c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/2603a18c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/2603a18c

Branch: refs/heads/master
Commit: 2603a18c28789701e3bae7871ff2adc97062a99c
Parents: f6d0007
Author: Aled Sage <aled.sage@gmail.com>
Authored: Wed Oct 15 12:46:54 2014 +0100
Committer: Aled Sage <aled.sage@gmail.com>
Committed: Wed Oct 15 15:18:38 2014 +0100

----------------------------------------------------------------------
 .../BrooklynLauncherRebindToCloudObjectStoreTest.java    | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/2603a18c/usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherRebindToCloudObjectStoreTest.java
----------------------------------------------------------------------
diff --git a/usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherRebindToCloudObjectStoreTest.java
b/usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherRebindToCloudObjectStoreTest.java
index e4462e3..f5576ad 100644
--- a/usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherRebindToCloudObjectStoreTest.java
+++ b/usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherRebindToCloudObjectStoreTest.java
@@ -41,9 +41,18 @@ import brooklyn.util.text.Identifiers;
 @Test(groups="Integration")
 public class BrooklynLauncherRebindToCloudObjectStoreTest extends BrooklynLauncherRebindTestFixture
{
 
+    // FIXME BrooklynLauncherRebindToCloudObjectStoreTest.testCleanDoesNotRebindToExistingApp
failed:
+    //     apps=[Application[mDNfOA7w]] expected [true] but found [false]
+    // Should it really delete everything in the bucket?! Only if we can back up first!
+
+    // FIXME brooklyn.util.exceptions.FatalRuntimeException: Error rebinding to persisted
state: Writes not allowed in brooklyn.entity.rebind.persister.BrooklynMementoPersisterToObjectStore@7d2f7563
+    //     at brooklyn.launcher.BrooklynLauncher.persistState(BrooklynLauncher.java:502)
+    //     at brooklyn.launcher.BrooklynLauncherRebindToCloudObjectStoreTest.testCopyPersistedState(BrooklynLauncherRebindToCloudObjectStoreTest.java:144)
+    // Presumably a previous run wasn't tearing down properly, so it joined as a standby
rather than being master?! 
+    
     { persistenceLocationSpec = BlobStoreTest.PERSIST_TO_OBJECT_STORE_FOR_TEST_SPEC; }
 
-    @BeforeMethod
+    @BeforeMethod(alwaysRun=true)
     public void setUp() throws Exception {
         persistenceDir = newTempPersistenceContainerName();
     }


Mime
View raw message