brooklyn-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rich...@apache.org
Subject [1/5] git commit: Ampersand is allowed unescaped in a double-quoted bash string
Date Fri, 06 Jun 2014 19:15:17 GMT
Repository: incubator-brooklyn
Updated Branches:
  refs/heads/master ba8209b65 -> 8e493f1cf


Ampersand is allowed unescaped in a double-quoted bash string


Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/14e6ed6e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/14e6ed6e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/14e6ed6e

Branch: refs/heads/master
Commit: 14e6ed6ea9ae08199b96832c0a96d791dc158dca
Parents: 17ee8c7
Author: Andrew Kennedy <andrew.kennedy@cloudsoftcorp.com>
Authored: Wed Jun 4 17:33:36 2014 +0100
Committer: Andrew Kennedy <andrew.kennedy@cloudsoftcorp.com>
Committed: Wed Jun 4 17:34:06 2014 +0100

----------------------------------------------------------------------
 utils/common/src/main/java/brooklyn/util/text/StringEscapes.java | 4 ----
 1 file changed, 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/14e6ed6e/utils/common/src/main/java/brooklyn/util/text/StringEscapes.java
----------------------------------------------------------------------
diff --git a/utils/common/src/main/java/brooklyn/util/text/StringEscapes.java b/utils/common/src/main/java/brooklyn/util/text/StringEscapes.java
index a568b8a..4d6c187 100644
--- a/utils/common/src/main/java/brooklyn/util/text/StringEscapes.java
+++ b/utils/common/src/main/java/brooklyn/util/text/StringEscapes.java
@@ -152,10 +152,6 @@ public class StringEscapes {
             if (x.matches(  "[^"+BACKSLASH+DOUBLE_QUOTE+"]*"+
                     "("+BACKSLASH+BACKSLASH+")*"+
                     DOUBLE_QUOTE+".*")) return "unescaped double quote";
-            //ampersand also must have odd number of backslashes before it; even number is
error
-            if (x.matches("[^"+BACKSLASH+BACKSLASH+"]*"+
-                    "("+BACKSLASH+BACKSLASH+")*"+
-                    "&"+".*")) return "unescaped ampersand";
             return null;
         }
 


Mime
View raw message