bookkeeper-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Enrico Olivelli <eolive...@gmail.com>
Subject Re: Help with bad errors on 4.6.1
Date Tue, 27 Mar 2018 08:55:39 GMT
End of this story
With this patch the problem does not occur anymore

https://github.com/apache/bookkeeper/pull/1293

The patch does not address directly the problem, the root source is still
unknown, this is very bad. But with that change no error is reported
anymore, so actually it is enough to go to production with java9 (10) and
my application.

I will start release process for 4.6.2 soon.

Thanks to everyone who helped

Enrico

Il ven 16 mar 2018, 12:30 Enrico Olivelli <eolivelli@gmail.com> ha scritto:

> resending (GMAIL webmail messed up prev email)
>
>
>
> 2018-03-16 10:34 GMT+01:00 Sijie Guo <guosijie@gmail.com>:
>
>> On Fri, Mar 16, 2018 at 2:26 AM, Enrico Olivelli <eolivelli@gmail.com>
>> wrote:
>>
>> > Thank you Sijie,
>> > I have already applied a similar patch to my local code based on 4.6.1
>> but
>> > the problem remains.
>> >
>>
>> What do you mean "the problem" here?
>>
>
> missing buf.release(), that you fixed on 4.7 and will cherry pick to 4.6
> branch
>
>
>
>> Do you mean the corruption problem or the leaking problem? The change I
>> pointed out only address the leaking problem. I don't think it is the
>> problem of corruption.
>>
>>
> Actually we are talking about a wire protocol level corruption.
> The only good "fix" that I have at the moment is to use use
> UnpooledByteBufAllocator.DEFAULT in encoder methods for v3
>
>
> Enrico
>
>
>
>
>
>>
>> >
>> > I am looking into Netty allocateUnitializedArray, which is used for
>> Pooled
>> > Heap Buffers.
>> > You all are more aware of BK code than me, is there any point in which
>> we
>> > assume that the buffer is full of zeroes ?
>> >
>> >
>> > Enrico
>> >
>> >
>> >
>> >
>> > 2018-03-16 10:22 GMT+01:00 Ivan Kelly <ivank@apache.org>:
>> >
>> > > > With "paranoid" log in Netty I found this that is very interesting,
>> but
>> > > it
>> > > > happens even on Java 8.
>> > > I don't think leaks are the problem here though. This seems to be more
>> > > like a doublefree issue.
>> > >
>> > > -Ivan
>> > >
>> >
>>
> --


-- Enrico Olivelli

Mime
View raw message