Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 620BA200CC2 for ; Wed, 5 Jul 2017 13:48:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 608051630BC; Wed, 5 Jul 2017 11:48:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7E9731630BB for ; Wed, 5 Jul 2017 13:48:30 +0200 (CEST) Received: (qmail 12139 invoked by uid 500); 5 Jul 2017 11:48:29 -0000 Mailing-List: contact user-help@bookkeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@bookkeeper.apache.org Delivered-To: mailing list user@bookkeeper.apache.org Received: (qmail 12129 invoked by uid 99); 5 Jul 2017 11:48:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2017 11:48:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8309CC0620 for ; Wed, 5 Jul 2017 11:48:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.38 X-Spam-Level: ** X-Spam-Status: No, score=2.38 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5UUwGPrZg5mk for ; Wed, 5 Jul 2017 11:48:26 +0000 (UTC) Received: from mail-qt0-f174.google.com (mail-qt0-f174.google.com [209.85.216.174]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A98345FACE for ; Wed, 5 Jul 2017 11:48:25 +0000 (UTC) Received: by mail-qt0-f174.google.com with SMTP id r30so183706370qtc.0 for ; Wed, 05 Jul 2017 04:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=UBExCLue3BOTDrXl2sroqncYzupqqIQBXE68In8/UN8=; b=Ko+15MUJkBYYdpbUQnwVSMI6QRcx1CQvaNsARn6n6kOeYye7foDKjeOy88o3LFRmX5 trgf9n5ihnAB/C6DyJqbsmWLcTNf2mzIoY7UsLoQ0OAViy7MYYXtQmIQ0xol/A6/M500 oQXf/UTPfHIZdUx5v6RKTklfjK2HcIvDkM1+Owbg+7xsn+V1aX5gnpgYx1XDT1LuATM9 YNZiFb5uIre+ltvafR7vlh4VnjNkFu9IANjWr9UdiZar8kO6ThsE14PdIB8bFSRpy+CH 0MNtO4qetfdcs9SklLGPuc3pL/VZHsZDV/20/C/KBcByF9lKhZHzGw5ha/UmckHi3xjU B9bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=UBExCLue3BOTDrXl2sroqncYzupqqIQBXE68In8/UN8=; b=OZOYalyTCMqKCgy+8DUKPJ/l9VSuWzA1pIjGH4tFn4nd81cQRCfjRPdt5vyO/Ft+Wp KNItLCygjRWAVRE5ucnKDMCzfwZX4Of0oEgIaA6Eg9smplz1+PebiHpZhXK5im+LFHY5 2cwTN7z027d1AB5QdqK286rB56DiDdmkSUh7b1KZiDSc+P5gy96eMG1QWzELbhTRYF9t /dw4r0zEs96hQMuFfLWpMBgmfLqpMcNoKoqDiE1kUzvpMEdkpxpcPHDJp9gHlAt1K00f wuLtoZLh40FLviPj/LLGgnSAzwx2brcFuMKjhJanxagACxI6VihC1D93YcBVezwfbQi7 YhlA== X-Gm-Message-State: AIVw112xImFq2uyi02KusDKI4aNVGe1fhryvM6+UrfSnXbnukuk9LFVy F+PxeGBlmzRyNw/WnMVBF7NCDkMqueqg X-Received: by 10.237.60.80 with SMTP id u16mr28824240qte.100.1499255298927; Wed, 05 Jul 2017 04:48:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Enrico Olivelli Date: Wed, 05 Jul 2017 11:48:07 +0000 Message-ID: Subject: Re: BookKeeper and CheckStyle To: user@bookkeeper.apache.org Content-Type: multipart/alternative; boundary="94eb2c190dc0852f8b05539093bf" archived-at: Wed, 05 Jul 2017 11:48:31 -0000 --94eb2c190dc0852f8b05539093bf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable David,, I see you have created an issue for the first part of bookkeeper-server. Maybe you can also create issues for every package, this way anyone can start working and we can easily coordinate such great effort. We are currently trying to switch to github issue tracker, this will a good opportunity to start using this new tool. Thank you John, feel free to pick up the issues, all help is really welcome ! Enrico Il mar 4 lug 2017, 21:47 John Lonergan ha scritto= : > Re"It contains almost 5000 issues." > > Have you put the gist somewhere for information. > Folk like myself are probably happy to contribute some time. It's an easy > way to contribute something to the community. > > JL > > On 4 Jul 2017 5:17 pm, "Enrico Olivelli" wrote: > >> >> >> Il mar 4 lug 2017, 18:06 D=C3=A1vid Szigecs=C3=A1n h= a scritto: >> >>> Hi, >>> >>> Yes, I created a PR for the first part of the change. (All modules exce= pt >>> bookkeeper-server) >>> I started to do the second part (bookkeeper-server), but It is a huge >>> change. It contains almost 5000 issues. >>> I'm thinking about how to slice it up to small steps. >>> >> >> Thank you David, >> Yep, the idea is to create a single patch per package if possible >> >> Enrico >> >> >>> 2017-07-04 17:06 GMT+02:00 Sijie Guo : >>> >>> > Those modules are fine, they are rarely touched any way. >>> > >>> > On Jul 4, 2017 8:57 AM, "Enrico Olivelli" wrote= : >>> > >>> > > 2017-07-04 16:50 GMT+02:00 Sijie Guo : >>> > > > It is fine to me if we do modules by modules and packages by >>> packages >>> > in >>> > > > bookkeeper-server. We can keep the changes smaller for reviews an= d >>> > easier >>> > > > to merge. >>> > > >>> > > I see in the issue and PR >>> > > https://github.com/apache/bookkeeper/pull/231 that he is adding CS >>> to >>> > > every maven module except from bookkeeper-server >>> > > maybe it is a good starting point. >>> > > I have written a comment in order to invite him to join the list >>> > > >>> > > I am also OK with applying such changes to bookkeeper-server one >>> > > package at a time >>> > > >>> > > -- Enrico >>> > > >>> > > > >>> > > > Also, it might be good to also discuss on the issue to keep David >>> > updated >>> > > > if he is not in the dev@ list. >>> > > > >>> > > > Sijie >>> > > > >>> > > > On Jul 4, 2017 6:43 AM, "Enrico Olivelli" >>> wrote: >>> > > > >>> > > > Hi all, >>> > > > as you can see from github emails there is an ongoing proposal to >>> add >>> > > > "checkstyle" plugin to BookKeeper build. >>> > > > I am really in favour of this change. It is already used in >>> > > > DistributedLog and it will ease the review, preventing us from >>> writing >>> > > > comments for minor typos. >>> > > > >>> > > > https://github.com/apache/bookkeeper/issues/230 >>> > > > https://github.com/apache/bookkeeper/issues/230 >>> > > > >>> > > > Thanks to David (I hope he is subscribed to this list) we will be >>> able >>> > > > to add this kind of support soon. >>> > > > >>> > > > My concern is that this change will make us change all big pull >>> > requests. >>> > > > >>> > > > We should decide when to get checkstyle in: >>> > > > 1) as soon as possible (after review of the patch) >>> > > > 2) before 4.5 release, as last step >>> > > > 3) after merging biggest changes (Twitter changes and Salesforce >>> > > > changes) which are waiting for review/merge >>> > > > 4) defer to the start of 4.6 >>> > > > >>> > > > My proposal is to defer to the start of 4.6, the only problem is >>> that >>> > > > David will be doing a big effort to keep the patch in synch with >>> the >>> > > > actual master >>> > > > >>> > > > -- Enrico >>> > > >>> > >>> >> -- >> >> >> -- Enrico Olivelli >> > -- -- Enrico Olivelli --94eb2c190dc0852f8b05539093bf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
David,,
I see you have created an issue for the first part o= f bookkeeper-server.
Maybe you can also create issues for every p= ackage, this way anyone can start working and we can easily coordinate such= great effort.

We are currently trying to switch t= o github issue tracker, this will a good opportunity to start using this ne= w tool.

Thank you John, feel free to pick up the i= ssues, all help is really welcome !

Enrico

Il mar 4 lug 2017, 21:47= John Lonergan <john.lonergan= @gmail.com> ha scritto:
Re&= quot;It contains almost 5000 issues."

Have yo= u put the gist somewhere for information.
Folk like myself are= probably happy to contribute some time. It's an easy way to contribute= something to the community.

JL

On 4 Jul 2017 5:17 pm, "Enrico Olivelli"= <eolivelli@gma= il.com> wrote:
Il mar 4 lug 2017, 18= :06 D=C3=A1vid Szigecs=C3=A1n <sigee15@gmail.com> ha scritto:
Hi,

Yes, I created a PR for the first part of the change. (All modules except bookkeeper-server)
I started to do the second part (bookkeeper-server), but It is a huge
change. It contains almost 5000 issues.
I'm thinking about how to slice it up to small steps.
<= /div>

Thank you David,
Yep, the idea is to c= reate a single patch per package if possible

Enric= o


2017-07-04 17:06 GMT+02:00 Sijie Guo <guosijie@gmail.com>:

> Those modules are fine, they are rarely touched any way.
>
> On Jul 4, 2017 8:57 AM, "Enrico Olivelli" <eolivelli@gmail.com> wrot= e:
>
> > 2017-07-04 16:50 GMT+02:00 Sijie Guo <guosijie@gmail.com>:
> > > It is fine to me if we do modules by modules and packages by= packages
> in
> > > bookkeeper-server. We can keep the changes smaller for revie= ws and
> easier
> > > to merge.
> >
> > I see in the issue and PR
> > https://github.com/apache/bookkeeper/pull/231= that he is adding CS to
> > every maven module except from bookkeeper-server
> > maybe it is a good starting point.
> > I have written a comment in order to invite him to join the list<= br> > >
> > I am also OK with applying such changes to bookkeeper-server one<= br> > > package at a time
> >
> > -- Enrico
> >
> > >
> > > Also, it might be good to also discuss on the issue to keep = David
> updated
> > > if he is not in the dev@ list.
> > >
> > > Sijie
> > >
> > > On Jul 4, 2017 6:43 AM, "Enrico Olivelli" <eolivelli@gmail.com> wrote:
> > >
> > > Hi all,
> > > as you can see from github emails there is an ongoing propos= al to add
> > > "checkstyle" plugin to BookKeeper build.
> > > I am really in favour of this change. It is already used in<= br> > > > DistributedLog and it will ease the review, preventing us fr= om writing
> > > comments for minor typos.
> > >
> > > https://github.com/apache/bookkeeper/i= ssues/230
> > > https://github.com/apache/bookkeeper/i= ssues/230
> > >
> > > Thanks to David (I hope he is subscribed to this list) we wi= ll be able
> > > to add this kind of support soon.
> > >
> > > My concern is that this change will make us change all big p= ull
> requests.
> > >
> > > We should decide when to get checkstyle in:
> > > 1) as soon as possible (after review of the patch)
> > > 2) before 4.5 release, as last step
> > > 3) after merging biggest changes (Twitter changes and Salesf= orce
> > > changes) which are waiting for review/merge
> > > 4) defer to the start of 4.6
> > >
> > > My proposal is to defer to the start of 4.6, the only proble= m is that
> > > David will be doing a big effort to keep the patch in synch = with the
> > > actual master
> > >
> > > -- Enrico
> >
>
--


-- Enrico Olivelli

--


-- Enrico Olivelli

--94eb2c190dc0852f8b05539093bf--