Mailing-List: contact user-help@bookkeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@bookkeeper.apache.org
MIME-Version: 1.0
In-Reply-To: <CAO2yDyZdcd1JJ+8=Wiy8q8rt8SVorGKXgno1fxsN0+dbF91a-w@mail.gmail.com>
References: <CACcefgc=9Jz=fhDKupVr2v2G9YxPZaStrtjySyfo1ACMKXZpwA@mail.gmail.com>
 <CAO2yDyZdcd1JJ+8=Wiy8q8rt8SVorGKXgno1fxsN0+dbF91a-w@mail.gmail.com>
From: Sijie Guo <guosijie@gmail.com>
Date: Fri, 31 Mar 2017 10:04:18 -0700
Message-ID: <CAO2yDyZsK5Qu-erpnUmRVrnyQfRKKtvNmXpNng7NM1eVptb53w@mail.gmail.com>
Subject: Re: New BookKeeper Proposal "Allow Reads outside the LAC Protocol"
To: dev@bookkeeper.apache.org
Cc: user@bookkeeper.apache.org
Content-Type: multipart/alternative; boundary=001a113b0850da6b29054c09cc94
archived-at: Fri, 31 Mar 2017 17:04:24 -0000

--001a113b0850da6b29054c09cc94
Content-Type: text/plain; charset=UTF-8

After taking a look at the proposal, I am not sure if making it a
configuration setting is the right approach.

However, I would suggest adding a method called #readUncommittedEntries -
it would skip the lac checking. so application can decide whether to use
readEntries (to read committed entries) or use readUncommittedEntries (to
read potentially *uncommitted* entries. So the correctness is managed by
application itself (out side of the logic).

- Sijie

On Thu, Mar 30, 2017 at 8:55 AM, Sijie Guo <guosijie@gmail.com> wrote:

> + dev@ and moved user@ to cc
>
> On Thu, Mar 30, 2017 at 8:26 AM, Enrico Olivelli <eolivelli@gmail.com>
> wrote:
>
>> I would like to share with the community this BookKeeper proposal
>>
>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-5+
>> Allow+reads+outside+the+LAC+Protocol
>>
>> I will submit a Pull Request to explain the modifications and provide
>> test cases
>>
>> All comments are welcome
>>
>> -- Enrico
>>
>
>

--001a113b0850da6b29054c09cc94
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">After taking a look at the proposal, I am not sure if maki=
ng it a configuration setting is the right approach.<div><br></div><div>How=
ever, I would suggest adding a method called #readUncommittedEntries - it w=
ould skip the lac checking. so application can decide whether to use readEn=
tries (to read committed entries) or use readUncommittedEntries (to read po=
tentially *uncommitted* entries. So the correctness is managed by applicati=
on itself (out side of the logic).</div><div><br></div><div>- Sijie</div></=
div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Thu, Mar 3=
0, 2017 at 8:55 AM, Sijie Guo <span dir=3D"ltr">&lt;<a href=3D"mailto:guosi=
jie@gmail.com" target=3D"_blank">guosijie@gmail.com</a>&gt;</span> wrote:<b=
r><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:=
1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">+ dev@ and moved user@ to=
 cc</div><div class=3D"HOEnZb"><div class=3D"h5"><div class=3D"gmail_extra"=
><br><div class=3D"gmail_quote">On Thu, Mar 30, 2017 at 8:26 AM, Enrico Oli=
velli <span dir=3D"ltr">&lt;<a href=3D"mailto:eolivelli@gmail.com" target=
=3D"_blank">eolivelli@gmail.com</a>&gt;</span> wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr"><div><div>I would like to share with the com=
munity this BookKeeper proposal<br><br><a href=3D"https://cwiki.apache.org/=
confluence/display/BOOKKEEPER/BP-5+Allow+reads+outside+the+LAC+Protocol" ta=
rget=3D"_blank">https://cwiki.apache.org/confl<wbr>uence/display/BOOKKEEPER=
/BP-5+<wbr>Allow+reads+outside+the+LAC+<wbr>Protocol</a><br><br></div>I wil=
l submit a Pull Request to explain the modifications and provide test cases=
<br><br></div><div>All comments are welcome<span class=3D"m_-16570759727497=
7841HOEnZb"><font color=3D"#888888"><br></font></span></div><span class=3D"=
m_-165707597274977841HOEnZb"><font color=3D"#888888"><div><br></div>-- Enri=
co<br></font></span></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>

--001a113b0850da6b29054c09cc94--