bookkeeper-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [bookkeeper] sijie commented on a change in pull request #2158: Avoid using directBuffer directly
Date Tue, 10 Sep 2019 21:58:03 GMT
sijie commented on a change in pull request #2158: Avoid using directBuffer directly
URL: https://github.com/apache/bookkeeper/pull/2158#discussion_r322981014
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/ReadCache.java
 ##########
 @@ -73,7 +73,7 @@ public ReadCache(ByteBufAllocator allocator, long maxCacheSize, int maxSegmentSi
         cacheIndexes = new ArrayList<>();
 
         for (int i = 0; i < segmentsCount; i++) {
-            cacheSegments.add(Unpooled.directBuffer(segmentSize, segmentSize));
+            cacheSegments.add(Unpooled.buffer(segmentSize, segmentSize));
 
 Review comment:
   what is the side effect of being pooled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message