From issues-return-13504-archive-asf-public=cust-asf.ponee.io@bookkeeper.apache.org  Mon Nov  5 23:45:48 2018
Return-Path: <issues-return-13504-archive-asf-public=cust-asf.ponee.io@bookkeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id AE24B18067A
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  5 Nov 2018 23:45:47 +0100 (CET)
Received: (qmail 83184 invoked by uid 500); 5 Nov 2018 22:45:46 -0000
Mailing-List: contact issues-help@bookkeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@bookkeeper.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@bookkeeper.apache.org>
List-Post: <mailto:issues@bookkeeper.apache.org>
List-Id: <issues.bookkeeper.apache.org>
Reply-To: dev@bookkeeper.apache.org
Delivered-To: mailing list issues@bookkeeper.apache.org
Received: (qmail 83175 invoked by uid 99); 5 Nov 2018 22:45:46 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Nov 2018 22:45:46 +0000
From: GitBox <git@apache.org>
To: issues@bookkeeper.apache.org
Subject: [GitHub] merlimat commented on a change in pull request #1784: Upgrade to
 Netty 4.1.31 and use individual dependencies
Message-ID: <154145794627.2024.8353928445061771509.gitbox@gitbox.apache.org>
Date: Mon, 05 Nov 2018 22:45:46 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

merlimat commented on a change in pull request #1784: Upgrade to Netty 4.1.31 and use individual dependencies
URL: https://github.com/apache/bookkeeper/pull/1784#discussion_r230942566
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -371,7 +371,58 @@
       </dependency>
       <dependency>
         <groupId>io.netty</groupId>
-        <artifactId>netty-all</artifactId>
+        <artifactId>netty-transport</artifactId>
+        <version>${netty.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-handler</artifactId>
+        <version>${netty.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-transport-native-epoll</artifactId>
+        <version>${netty.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-transport-native-epoll</artifactId>
+        <version>${netty.version}</version>
+        <classifier>linux-x86_64</classifier>
+      </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-codec-dns</artifactId>
+        <version>${netty.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-codec-http</artifactId>
+        <version>${netty.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-codec-http2</artifactId>
+        <version>${netty.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-codec-socks</artifactId>
 
 Review comment:
   This is already being pulled by other dependencies (eg: finagle, etc..). Here, I'm not adding a new dependency, just pinning all the artifacts to be on the same version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services