bookkeeper-distributedlog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiazhai <>
Subject [GitHub] incubator-distributedlog pull request #133: DL-124: Use Java8 Future rather ...
Date Sat, 03 Jun 2017 11:06:29 GMT
Github user jiazhai commented on a diff in the pull request:
    --- Diff: distributedlog-core/src/main/java/org/apache/distributedlog/
    @@ -483,23 +482,23 @@ protected long assignLogSegmentSequenceNumber() throws IOException
         protected BKLogSegmentWriter doStartLogSegment(long txId, boolean bestEffort, boolean
allowMaxTxID) throws IOException {
    -        return FutureUtils.result(asyncStartLogSegment(txId, bestEffort, allowMaxTxID));
    +        return Utils.ioResult(asyncStartLogSegment(txId, bestEffort, allowMaxTxID));
    -    protected Future<BKLogSegmentWriter> asyncStartLogSegment(final long txId,
    +    protected CompletableFuture<BKLogSegmentWriter> asyncStartLogSegment(final
long txId,
                                                                   final boolean bestEffort,
    --- End diff --
    Please also do the code alignment change here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message