bookkeeper-distributedlog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liang Xie (JIRA)" <>
Subject [jira] [Created] (DL-84) Reduce HashedWheelTimer instance number
Date Mon, 05 Dec 2016 07:29:58 GMT
Liang Xie created DL-84:

             Summary: Reduce HashedWheelTimer instance number
                 Key: DL-84
             Project: DistributedLog
          Issue Type: Improvement
          Components: distributedlog-client, distributedlog-core, distributedlog-service
    Affects Versions: 0.4.0, 0.5.0
            Reporter: Liang Xie
            Assignee: Liang Xie

Reading code and finding that we use HashedWheelTimer in OwnershipCache Class, from netty
HashedWheelTimer java doc we know:
Do not create many instances.
HashedWheelTimer creates a new thread whenever it is instantiated and started. Therefore,
you should make sure to create only one instance and share it across your application
then i grep the code base and found more than ten HashedWheelTimer instantces be created seems.
i think the current code could be improved to reduce the thread num:)

This message was sent by Atlassian JIRA

View raw message