bookkeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [bookkeeper] branch branch-4.6 updated: Fixed Journal stats names
Date Wed, 14 Mar 2018 00:01:52 GMT
This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch branch-4.6
in repository

The following commit(s) were added to refs/heads/branch-4.6 by this push:
     new e248147  Fixed Journal stats names
e248147 is described below

commit e248147463281986d29d75d959732834f4225a9b
Author: Matteo Merli <>
AuthorDate: Tue Mar 13 16:49:50 2018 -0700

    Fixed Journal stats names
    In `BOOKKEEPER-1009: Use multiple journals in bookie` 123eccd435a4a96a9147ed4a24efbe9025fe79ba
there was a change in the metrics name that would be affecting also user not running with
multiple journal.
    It is a bit inconvenient to aggregate the stats in the metrics collector (how to aggregate
99pct latency for example).
    I think the best option is to have a single metric even when using multiple journal threads.
    Author: Matteo Merli <>
    Reviewers: Ivan Kelly <>, Enrico Olivelli <>,
Sijie Guo <>
    This closes #1250 from merlimat/journal-metric-names
    (cherry picked from commit 4578e6d65a304c870fcba013099badd6018c95de)
    Signed-off-by: Sijie Guo <>
 .../src/main/java/org/apache/bookkeeper/bookie/              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/
index 074c29c..711b2b8 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/
@@ -695,7 +695,7 @@ public class Bookie extends BookieCriticalThread {
         journals = Lists.newArrayList();
         for (int i = 0; i < journalDirectories.size(); i++) {
             journals.add(new Journal(journalDirectories.get(i),
-                         conf, ledgerDirsManager, statsLogger.scope(JOURNAL_SCOPE + "_" +
+                         conf, ledgerDirsManager, statsLogger.scope(JOURNAL_SCOPE)));
         CheckpointSource checkpointSource = new CheckpointSourceList(journals);

To stop receiving notification emails like this one, please contact

View raw message