Mailing-List: contact commits-help@bookkeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bookkeeper-dev@bookkeeper.apache.org
Date: Fri, 20 Oct 2017 22:19:15 +0000
To: "commits@bookkeeper.apache.org" <commits@bookkeeper.apache.org>
Subject: [bookkeeper] branch master updated: Increase timeouts in
 TestDisableEnsembleChange
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Message-ID: <150853795571.15785.8580862106093570333@gitbox.apache.org>
From: ivank@apache.org
Auto-Submitted: auto-generated
archived-at: Fri, 20 Oct 2017 22:19:19 -0000

This is an automated email from the ASF dual-hosted git repository.

ivank pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 51a58cb  Increase timeouts in TestDisableEnsembleChange
51a58cb is described below

commit 51a58cbe3ad6ca7833f433aa9b845480ee690e57
Author: Ivan Kelly <ivank@apache.org>
AuthorDate: Sat Oct 21 00:19:08 2017 +0200

    Increase timeouts in TestDisableEnsembleChange
    
    In some narrow cases, if we manage to connect to the bookie, but the bookie
    hasn't fully initialized, an add entry message will be dropped, and the
    client will wait for the timeout to complete. The timeout is 5 seconds
    by default, which was 5x the timeout in the test. This patch increases
    the test timeout to 10s, which should give enough time for the addEntry
    to fail and be retried.
    
    Author: Ivan Kelly <ivan@midokura.com>
    
    Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>
    
    This closes #646 from ivankelly/ensemble-change-test
---
 .../java/org/apache/bookkeeper/client/TestDisableEnsembleChange.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestDisableEnsembleChange.java b/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestDisableEnsembleChange.java
index 2627016..9b26ab1 100644
--- a/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestDisableEnsembleChange.java
+++ b/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestDisableEnsembleChange.java
@@ -206,7 +206,7 @@ public class TestDisableEnsembleChange extends BookKeeperClusterTestCase {
         bsConfs.add(killedConf);
         bs.add(startBookie(killedConf));
         assertTrue("Add entry operation should complete at this point.",
-                addLatch.await(1000, TimeUnit.MILLISECONDS));
+                addLatch.await(10000, TimeUnit.MILLISECONDS));
         assertEquals(res.get(), BKException.Code.OK);
     }
 
@@ -270,7 +270,7 @@ public class TestDisableEnsembleChange extends BookKeeperClusterTestCase {
         // wakeup the sleep bookie
         wakeupLatch.countDown();
         assertTrue("Add entry operation should complete at this point.",
-                addLatch.await(1000, TimeUnit.MILLISECONDS));
+                addLatch.await(10000, TimeUnit.MILLISECONDS));
         assertEquals(res.get(), BKException.Code.OK);
     }
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@bookkeeper.apache.org" <commits@bookkeeper.apache.org>'].