bookkeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From si...@apache.org
Subject [bookkeeper] branch master updated: ISSUE #492: set the protobuf syntax to 'proto2'
Date Wed, 06 Sep 2017 01:28:47 GMT
This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new e48f9d0  ISSUE #492: set the protobuf syntax to 'proto2'
e48f9d0 is described below

commit e48f9d02924208ad1e929c2876ae2acfcfab0c5d
Author: Jia Zhai <zhaijia@apache.org>
AuthorDate: Tue Sep 5 18:28:40 2017 -0700

    ISSUE #492: set the protobuf syntax to 'proto2'
    
    Descriptions of the changes in this PR:
    
    Explicitly set protobuf syntax to `proto2`.
    
    Author: Jia Zhai <zhaijia@apache.org>
    
    Reviewers: Sijie Guo <sijie@apache.org>
    
    This closes #493 from zhaijack/metadata/set_protobuf_syntax_version, closes #492
---
 bookkeeper-server/src/main/proto/BookkeeperProtocol.proto | 5 +++--
 bookkeeper-server/src/main/proto/DataFormats.proto        | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/bookkeeper-server/src/main/proto/BookkeeperProtocol.proto b/bookkeeper-server/src/main/proto/BookkeeperProtocol.proto
index 309987c..b43e691 100644
--- a/bookkeeper-server/src/main/proto/BookkeeperProtocol.proto
+++ b/bookkeeper-server/src/main/proto/BookkeeperProtocol.proto
@@ -14,9 +14,10 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+syntax = "proto2";
 
- option java_package = "org.apache.bookkeeper.proto";
- option optimize_for = SPEED;
+option java_package = "org.apache.bookkeeper.proto";
+option optimize_for = SPEED;
 
 /**
  * Protocol Versions.
diff --git a/bookkeeper-server/src/main/proto/DataFormats.proto b/bookkeeper-server/src/main/proto/DataFormats.proto
index b4ce86d..cdade95 100644
--- a/bookkeeper-server/src/main/proto/DataFormats.proto
+++ b/bookkeeper-server/src/main/proto/DataFormats.proto
@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+syntax = "proto2";
+
 option java_package = "org.apache.bookkeeper.proto";
 option optimize_for = SPEED;
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@bookkeeper.apache.org" <commits@bookkeeper.apache.org>'].

Mime
View raw message