bookkeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From si...@apache.org
Subject [bookkeeper] branch master updated: Fix navbar hover issue on the main page
Date Wed, 02 Aug 2017 20:52:25 GMT
This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 23f9d81  Fix navbar hover issue on the main page
23f9d81 is described below

commit 23f9d815f1f7fa6fa3df55883fa2ec22535d1d2b
Author: Luc Perkins <lucperkins@gmail.com>
AuthorDate: Wed Aug 2 13:52:17 2017 -0700

    Fix navbar hover issue on the main page
    
    This PR fixes the navbar dropdown UX issue shown in the attached image.
    
    <img width="681" alt="screen shot 2017-08-02 at 10 04 20 am" src="https://user-images.githubusercontent.com/1523104/28886622-05333fcc-776f-11e7-8bea-163f60acaaa1.png">
    
    Author: Luc Perkins <lucperkins@gmail.com>
    
    Reviewers: Matteo Merli <mmerli@apache.org>, Sijie Guo <sijie@apache.org>
    
    This closes #370 from lucperkins/docs/fix-dropdown
---
 site/_includes/navbar.html | 196 ++++++++++++++++++++++-----------------------
 1 file changed, 97 insertions(+), 99 deletions(-)

diff --git a/site/_includes/navbar.html b/site/_includes/navbar.html
index 30deb5f..cb8c18a 100644
--- a/site/_includes/navbar.html
+++ b/site/_includes/navbar.html
@@ -1,114 +1,112 @@
 {% capture docs_url %}{{ site.baseurl }}docs/{% endcapture %}
-<div class="bk-topnav">
-  <nav class="navbar">
-    <div class="navbar-brand">
-      <a class="navbar-item bk-brand" href="{{ site.baseurl }}">
-        {{ site.title }}
-      </a>
+<nav class="navbar bk-topnav">
+  <div class="navbar-brand">
+    <a class="navbar-item bk-brand" href="{{ site.baseurl }}">
+      {{ site.title }}
+    </a>
 
-      <!--
-      <a class="navbar-item is-hidden-desktop bk-github" href="{{ site.github_repo }}"
target="_blank">
-        <span class="icon">
-          <i class="fa fa-github"></i>
-        </span>
-      </a>
+    <!--
+    <a class="navbar-item is-hidden-desktop bk-github" href="{{ site.github_repo }}" target="_blank">
+      <span class="icon">
+        <i class="fa fa-github"></i>
+      </span>
+    </a>
 
-      <a class="navbar-item is-hidden-desktop bk-twitter" href="https://twitter.com/jgthms"
target="_blank">
-        <span class="icon">
-          <i class="fa fa-twitter"></i>
-        </span>
-      </a>
-      -->
+    <a class="navbar-item is-hidden-desktop bk-twitter" href="https://twitter.com/jgthms"
target="_blank">
+      <span class="icon">
+        <i class="fa fa-twitter"></i>
+      </span>
+    </a>
+    -->
 
-      <div class="navbar-burger" data-target="bkNav">
-        <span></span>
-        <span></span>
-        <span></span>
-      </div>
+    <div class="navbar-burger" data-target="bkNav">
+      <span></span>
+      <span></span>
+      <span></span>
     </div>
+  </div>
 
-    <div id="bkNav" class="navbar-menu">
-      <div class="navbar-start">
-        <div class="navbar-item has-dropdown is-hoverable">
-          <a class="navbar-link">Documentation</a>
-          <div class="navbar-dropdown is-boxed">
-            {% for version in site.versions %}
-            <a class="navbar-item" href="{{ site.baseurl }}docs/getting-started/installation">
-              Release {{version}}
-              {% if version == site.latest %}<span class="tag is-success">LATEST</span>{%
endif %}
-            </a>
-            {% endfor %}
-            <hr class="dropdown-divider">
-            <a class="navbar-item" href="{{ site.baseurl }}javadoc">
-              <span class="icon bk-javadoc-icon">
-                <img src="{{ site.baseurl }}img/java-icon.svg">
-              </span>
-              Javadoc
-            </a>
-            <hr class="dropdown-divider">
-            {% for version in site.archived_versions %}
-            <a class="navbar-item" href="{{ site.archived_releases_url }}{{version}}">
-              Release {{version}}
-              {% if version == site.stable_release %}<span class="tag is-success">Stable</span>{%
endif %}
-            </a>
-            {% endfor %}
-          </div>
+  <div id="bkNav" class="navbar-menu">
+    <div class="navbar-start">
+      <div class="navbar-item has-dropdown is-hoverable">
+        <a class="navbar-link">Documentation</a>
+        <div class="navbar-dropdown is-boxed">
+          {% for version in site.versions %}
+          <a class="navbar-item" href="{{ site.baseurl }}docs/getting-started/installation">
+            Release {{version}}
+            {% if version == site.latest %}<span class="tag is-success">LATEST</span>{%
endif %}
+          </a>
+          {% endfor %}
+          <hr class="dropdown-divider">
+          <a class="navbar-item" href="{{ site.baseurl }}javadoc">
+            <span class="icon bk-javadoc-icon">
+              <img src="{{ site.baseurl }}img/java-icon.svg">
+            </span>
+            Javadoc
+          </a>
+          <hr class="dropdown-divider">
+          {% for version in site.archived_versions %}
+          <a class="navbar-item" href="{{ site.archived_releases_url }}{{version}}">
+            Release {{version}}
+            {% if version == site.stable_release %}<span class="tag is-success">Stable</span>{%
endif %}
+          </a>
+          {% endfor %}
         </div>
+      </div>
 
-        <div class="navbar-item has-dropdown is-hoverable">
-          <a class="navbar-link">Community</a>
-          <div class="navbar-dropdown is-boxed">
-            <a class="navbar-item" href="{{ site.baseurl }}community/mailing-lists">Mailing
lists</a>
-            <a class="navbar-item" href="{{ site.baseurl }}community/slack">Slack</a>
-            <a class="navbar-item" href="{{ site.baseurl }}community/contributing">Contributing</a>
-            <a class="navbar-item" href="https://issues.apache.org/jira/projects/BOOKKEEPER">JIRA
Issue Tracker</a>
-          </div>
+      <div class="navbar-item has-dropdown is-hoverable">
+        <a class="navbar-link">Community</a>
+        <div class="navbar-dropdown is-boxed">
+          <a class="navbar-item" href="{{ site.baseurl }}community/mailing-lists">Mailing
lists</a>
+          <a class="navbar-item" href="{{ site.baseurl }}community/slack">Slack</a>
+          <a class="navbar-item" href="{{ site.baseurl }}community/contributing">Contributing</a>
+          <a class="navbar-item" href="https://issues.apache.org/jira/projects/BOOKKEEPER">JIRA
Issue Tracker</a>
         </div>
-        
-        <div class="navbar-item has-dropdown is-hoverable">
-          <a class="navbar-link">Project</a>
-          <div class="navbar-dropdown is-boxed">
-            <a class="navbar-item" href="{{ site.baseurl }}project/who">Who are we?</a>
-            <a class="navbar-item" href="{{ site.baseurl }}project/bylaws">Bylaws</a>
-            <a class="navbar-item" href="http://www.apache.org/licenses/">License</a>
-            <hr class="dropdown-divider">
-            <a class="navbar-item" href="{{ site.baseurl }}project/privacy">Privacy
policy</a>
-            <a class="navbar-item" href="http://www.apache.org/foundation/sponsorship.html">Sponsorship</a>
-            <a class="navbar-item" href="http://www.apache.org/foundation/thanks.html">Thanks</a>
-          </div>
+      </div>
+
+      <div class="navbar-item has-dropdown is-hoverable">
+        <a class="navbar-link">Project</a>
+        <div class="navbar-dropdown is-boxed">
+          <a class="navbar-item" href="{{ site.baseurl }}project/who">Who are we?</a>
+          <a class="navbar-item" href="{{ site.baseurl }}project/bylaws">Bylaws</a>
+          <a class="navbar-item" href="http://www.apache.org/licenses/">License</a>
+          <hr class="dropdown-divider">
+          <a class="navbar-item" href="{{ site.baseurl }}project/privacy">Privacy policy</a>
+          <a class="navbar-item" href="http://www.apache.org/foundation/sponsorship.html">Sponsorship</a>
+          <a class="navbar-item" href="http://www.apache.org/foundation/thanks.html">Thanks</a>
         </div>
       </div>
+    </div>
 
-      <div class="navbar-end">
-        <div class="navbar-item">
-          <div class="field is-grouped">
-            <p class="control">
-              <a class="button bk-twitter" href="{{ site.twitter_url }}">
-                <span class="icon">
-                  <i class="fa fa-twitter"></i>
-                </span>
-                <span>Twitter</span>
-              </a>
-            </p>
-            <p class="control">
-              <a class="button" href="{{ site.github_repo }}">
-                <span class="icon">
-                  <i class="fa fa-github"></i>
-                </span>
-                <span>GitHub</span>
-              </a>
-            </p>
-            <p class="control">
-              <a class="button is-primary" href="{{ site.baseurl }}releases">
-                <span class="icon">
-                  <i class="fa fa-download"></i>
-                </span>
-                <span>Download</span>
-              </a>
-            </p>
-          </div>
+    <div class="navbar-end">
+      <div class="navbar-item">
+        <div class="field is-grouped">
+          <p class="control">
+            <a class="button bk-twitter" href="{{ site.twitter_url }}">
+              <span class="icon">
+                <i class="fa fa-twitter"></i>
+              </span>
+              <span>Twitter</span>
+            </a>
+          </p>
+          <p class="control">
+            <a class="button" href="{{ site.github_repo }}">
+              <span class="icon">
+                <i class="fa fa-github"></i>
+              </span>
+              <span>GitHub</span>
+            </a>
+          </p>
+          <p class="control">
+            <a class="button is-primary" href="{{ site.baseurl }}releases">
+              <span class="icon">
+                <i class="fa fa-download"></i>
+              </span>
+              <span>Download</span>
+            </a>
+          </p>
         </div>
       </div>
     </div>
-  </nav>
-</div>
+  </div>
+</nav>

-- 
To stop receiving notification emails like this one, please contact
['"commits@bookkeeper.apache.org" <commits@bookkeeper.apache.org>'].

Mime
View raw message