bookkeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From si...@apache.org
Subject [bookkeeper] branch master updated: ISSUE #216: Remove useless and misleading '&= true'
Date Wed, 28 Jun 2017 21:09:45 GMT
This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new fe8ded5  ISSUE #216: Remove useless and misleading '&= true'
fe8ded5 is described below

commit fe8ded50ed8f008457665138ec0e6a88bba67f73
Author: Diego Salvi <lothruin.mirwen@gmail.com>
AuthorDate: Wed Jun 28 14:09:37 2017 -0700

    ISSUE #216: Remove useless and misleading '&= true'
    
    This is just a super minor issue, I stumbled upon it looking into https://github.com/apache/bookkeeper/pull/58...
    
    Assignments like 'shutDownTask =& true' aren't useful at all. I presume that compiler
could strip them out but the code is less readable. (Just note that 'x & true == x').
    
    Removed useless assignments.
    
    Author: Diego Salvi <lothruin.mirwen@gmail.com>
    
    Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>
    
    This closes #215 from diegosalvi/master, closes #216
---
 .../src/main/java/org/apache/bookkeeper/replication/Auditor.java      | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
index 338584a..9e7d034 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
@@ -370,17 +370,13 @@ public class Auditor implements BookiesListener {
             shutDownTask = false;
         } catch (BKException bke) {
             LOG.error("Exception getting bookie list", bke);
-            shutDownTask &= true;
         } catch (InterruptedException ie) {
             Thread.currentThread().interrupt();
             LOG.error("Interrupted while watching available bookies ", ie);
-            shutDownTask &= true;
         } catch (BKAuditException bke) {
             LOG.error("Exception while watching available bookies", bke);
-            shutDownTask &= true;
         } catch (KeeperException ke) {
             LOG.error("Exception reading bookie list", ke);
-            shutDownTask &= true;
         }
         if (shutDownTask) {
             submitShutdownTask();

-- 
To stop receiving notification emails like this one, please contact
['"commits@bookkeeper.apache.org" <commits@bookkeeper.apache.org>'].

Mime
View raw message