bloodhound-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Ollos <ryan.ol...@wandisco.com>
Subject Re: Error while trying to diff source files/directories
Date Wed, 18 Dec 2013 00:32:57 GMT
On Sat, Dec 14, 2013 at 7:33 AM, Olemis Lang <olemis@gmail.com> wrote:

> [...]
>
>>
>> The issue you are seeing is a defect in Bloodhound. We are ignoring
>> requests to the path `/diff` at global scope:
>>
>> https://issues.apache.org/bloodhound/browser/trunk/bloodhound_multiproduct/multiproduct/web_ui.py?rev=1522803#L41
>>
>
> weird ...
>
>
>> There are probably some good reasons for that,
>>
>
> I see no reason to do so *in that particular location* . Ignoring such
> paths is due to redirections to global product and :
>
>   1. this has been deprecated
>   2. and is caused by the behavior of default web bootstrap handler (wbh)
> and request hooks
>
> so I want to dig a bit deeper before making any changes.
>>
>
> ... and therefore IMO such decisions should be implemented only when
> running default wbh and/or hooks , so I suggest to move this from web_ui.py
> to hooks.py
>
>
I committed a change to allow requests to the path `/diff` at global scope.
I took a look at the code to try to understand your suggestion of moving it
from web_ui.py to hooks.py, but it's not clear to me how to make this
change. Would you mind posting a patch with your suggested change?

Mime
View raw message