Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of brane@wandisco.com designates
 209.85.215.180 as permitted sender)
Message-ID: <514C2E6B.6070704@wandisco.com>
Date: Fri, 22 Mar 2013 11:11:55 +0100
From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@wandisco.com>
Organization: WANdisco
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:17.0) Gecko/20130307 Thunderbird/17.0.4
MIME-Version: 1.0
To: bloodhound-dev@incubator.apache.org
Subject: Re: [REGRESSION] What should be italics is rendered as bold text
 WAS: svn commit: r1456892 -
 /incubator/bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css
References: 
 <CAGMZAuNY_X58fXYAEDnXE3cv0+A2ZivCSGKk4WDJKoq2JVihLw@mail.gmail.com>
 <CAPt9QwS8Vmto77U_b+iEQdAsj7dbsOi0LSa2iu=MOhjJ7L_H-g@mail.gmail.com>
 <CAGMZAuPg6wdLRC+wYuX-LSMn5LSDyci=RvRr7qjTMsDE3KpcOg@mail.gmail.com>
 <CAPt9QwTB0G__L5KFpFo8-MrhwbZrx73iLtWh07Si6GqUHsX7oQ@mail.gmail.com>
 <CAHkeAeyF_-tn5nVNWfG+frAFYnwP9AkrL7Sb28WsuTTicP2qGQ@mail.gmail.com>
In-Reply-To: 
 <CAHkeAeyF_-tn5nVNWfG+frAFYnwP9AkrL7Sb28WsuTTicP2qGQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 22.03.2013 10:24, Anze Staric wrote:
> The change was introduced in r1452190 with match highlighting in
> search. The tag <em> was chosen as the tag to mark matches based on
> the default choise of Solr (<em> for emphasis -
> http://lucene.apache.org/solr/4_1_0/tutorial.html#Highlighting).
>
> Css was modified to match the look of the google search results (bold
> matches). As it only changes style inside elements marked as
> searchable it was not supposed to break anything outside the search
> results. I forgot to check whether the css class was used in other
> contexts. The following patch replaces the name of the class marking
> the search results that need to be highlighted.

<em>phasis does not imply italic text, so in general it's fine to have
bold emphasis instead of italic (or underlined, or different font or
colour, or whatever). Since the definitions is scoped within
class=highlight_matches, I don't really see a problem.

-- Brane


-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com