Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: bloodhound-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of matevzb@gmail.com designates
 209.85.219.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <50B7D94F.7060706@wandisco.com>
References: 
 <CA+DjKZc4rh9Fd6Th=kvVQMD3qpnZ+cyjh=K-EHwjo0zcv_P3TQ@mail.gmail.com>
 <CAJSKAsjgAQMwMNFwO2CNyTR71mLpk0rVmR44OdVcfCa8aBztWg@mail.gmail.com>
 <2BA32F18-E010-433A-8E9F-359192ABA8F8@wandisco.com>
 <CA+DjKZcBwnEJfn5VLdET79WF2buQu1r_xcHVcJp1h=2KFefFgA@mail.gmail.com>
 <CA+DjKZce2r0Ke7BRutgtebAT-sNj=9XMAiPnbmTX8fvAaMDyoQ@mail.gmail.com>
 <50B7D94F.7060706@wandisco.com>
From: Matevz Bradac <matevzb@gmail.com>
Date: Sat, 1 Dec 2012 17:08:03 +0100
Message-ID: 
 <CA+DjKZdxi=kgm74sJHE1CP+Kj6RTp1AVQFx_L2Ejsw43SK9phQ@mail.gmail.com>
Subject: Re: Genshi XHTML + HTML 5
To: bloodhound-dev@incubator.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thanks. I wanted to avoid monkeypatching render_template(), as it's
not a small/trivial function.
There may be better candidates for this though, such as the Stream.serializ=
e().
Which brings up another question - if we do override trac's functions,
should we keep a list of such
changes somewhere, so that when we introduce a new trac version into
BH things get synced properly?

--
matevz

On Thu, Nov 29, 2012 at 10:53 PM, Branko =C4=8Cibej <brane@wandisco.com> wr=
ote:
> On 29.11.2012 22:02, Matevz Bradac wrote:
>> Would it be possible to do this in the post processing phase, i.e.
>> IRequestFilter's post_process_request()?
>> If not, is there any way of overriding trac's behaviour without
>> modifying trac itself?
>
> Sure is.
>
> def better_render_template(self, etc...)
>   pass
>
> import chrome
> chrome.Chrome.render_template =3D better_render_template
>
> This change will persist for the duration of the Python interpreter,
> even across subsequent "import chrome" statements. It's best to do this
> very early during BH intialization.
>
> N.B.: I haven't actually looked at what the names of the modules
> actually are, but you get the idea.
>
> -- Brane
>
> --
> Branko =C4=8Cibej
> Director of Subversion | WANdisco | www.wandisco.com
>