Return-Path: X-Original-To: apmail-incubator-bloodhound-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-bloodhound-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 525C4D5B9 for ; Mon, 3 Dec 2012 08:27:11 +0000 (UTC) Received: (qmail 19922 invoked by uid 500); 3 Dec 2012 08:27:10 -0000 Delivered-To: apmail-incubator-bloodhound-dev-archive@incubator.apache.org Received: (qmail 19817 invoked by uid 500); 3 Dec 2012 08:27:08 -0000 Mailing-List: contact bloodhound-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: bloodhound-dev@incubator.apache.org Delivered-To: mailing list bloodhound-dev@incubator.apache.org Received: (qmail 19788 invoked by uid 99); 3 Dec 2012 08:27:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2012 08:27:06 +0000 X-ASF-Spam-Status: No, hits=2.8 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_BLACK X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of matevzb@gmail.com designates 209.85.219.47 as permitted sender) Received: from [209.85.219.47] (HELO mail-oa0-f47.google.com) (209.85.219.47) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2012 08:27:00 +0000 Received: by mail-oa0-f47.google.com with SMTP id h1so2334058oag.6 for ; Mon, 03 Dec 2012 00:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=b2gQhDoyRj+Tqj2pi+VPHGr7JwOTwwJsOxzUGr0NewA=; b=i9uM2mgYSNC1Q6CLWicW+ujVfjQ4qD1dnhjPeXqcfoDiDwlhCyuY4MjsIwmR9Cqo7U uRf3zU38oEJWGpn+K4lPsg18QlkSf0SvX6nHwNJ4Lw2Ksxf6cdT8lb92arupDdiy4vFw nAJR/3iFjnQzpBnRzEKKpSI/JUD+1r0O/NJDbXxACqKoqS0WxXMo7vUZu+Ny/TzIZ174 jpohIIcMYQYP8UiIJqveYjA6cHT8LzDQG9ur/FohSAlSExb4cwsrIiV5MdZkUwbgVbJK 0UA7WWxyhfCul9hWL21p3OTOiKGNuxFR+4h9v05eRgseC/56QHrEW0/vc6P5kE2o6XEH IXbw== Received: by 10.182.92.70 with SMTP id ck6mr3755148obb.46.1354523199061; Mon, 03 Dec 2012 00:26:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.73.138 with HTTP; Mon, 3 Dec 2012 00:25:58 -0800 (PST) In-Reply-To: References: <2BA32F18-E010-433A-8E9F-359192ABA8F8@wandisco.com> From: Matevz Bradac Date: Mon, 3 Dec 2012 09:25:58 +0100 Message-ID: Subject: Re: Genshi XHTML + HTML 5 To: bloodhound-dev@incubator.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org Hi, Great, thanks for all the suggestions. =) I'll start working on trac changes then, it would make more sense to make trac itself more configurable than to create workarounds within bloodhound (and possibly other projects based on trac). -- matevz On Mon, Dec 3, 2012 at 12:52 AM, Olemis Lang wrote: > Hi ! > > On 12/2/12, Matevz Bradac wrote: >> I tried solving this on the stream level, but no luck so far. > > However you have been doing an extraordinary research here . Good work . > :) > > [...] >> >> Due to the above complications (and those not yet discovered), I'd say >> it would be easier and less error-prone >> to just override the genshi.output.get_serializer() with BH's wrapper. >> The function is pretty trivial and unlikely >> to change much, so it looks like a safe alternative. >> > > I'm not very aware of the details . Nonetheless I'd just say for the > moment that there's more chance to accept a patch (i.e. not > monkeypatching ;) for Chrome.render_template than another for Genshi . > In the end we are already distributing a modified copy of Trac , so > patches of this kind are welcome , especially if there's a good reason > to do so . So at this point don't be afraid of proposing a refactoring > for that method in order to be able to choose another doctype . Just > try to keep it as compatible with previous solution as possible , > since there is no need to break Trac if e.g. Bloodhound theme is > disabled > > OTOH creating another vendor branch for Genshi is quite unlikely to > happen soon . > > Keep up the good work ! > ;) > > -- > Regards, > > Olemis. > > Blog ES: http://simelo-es.blogspot.com/ > Blog EN: http://simelo-en.blogspot.com/ > > Featured article: