bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject [Apache Bloodhound] #298: Exception from missing req.chrome['labels'] in filter_stream
Date Wed, 12 Dec 2012 09:52:24 GMT
#298: Exception from missing req.chrome['labels'] in filter_stream
-----------------------+-----------------------
 Reporter:  gjm        |      Owner:  nobody
     Type:  defect     |     Status:  new
 Priority:  major      |  Milestone:  Release 4
Component:  dashboard  |    Version:
 Keywords:             |
-----------------------+-----------------------
 This is related to #294 in a sense as it is another case when the
 {{{req.chrome['labels']}}} dictionary is potentially unavailable. In the
 former case it was because it was causing premature lazy evaluation,
 before a function was curried to specify the ultimate handler.

 This new case is may be because an exception can stop the
 {{{post_process_request}}} from executing so that it is not available in
 the {{{filter_stream}}} method, where it is now required so that errors
 are correctly whitelabelled.

 I suggest that we move the whitelabelling config evaluation into a
 separate helper method (in case there are situations where the dictionary
 is required elsewhere) and add {{{req.chrome['labels']}}} in the
 {{{filter_stream}}} method.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/298>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message