Return-Path: 
 <bloodhound-commits-return-758-apmail-incubator-bloodhound-commits-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-bloodhound-commits-archive@minotaur.apache.org
Delivered-To: apmail-incubator-bloodhound-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EFB9F957F
	for <apmail-incubator-bloodhound-commits-archive@minotaur.apache.org>;
 Thu, 14 Jun 2012 09:55:07 +0000 (UTC)
Received: (qmail 98830 invoked by uid 500); 14 Jun 2012 09:55:07 -0000
Delivered-To: apmail-incubator-bloodhound-commits-archive@incubator.apache.org
Received: (qmail 98777 invoked by uid 500); 14 Jun 2012 09:55:06 -0000
Mailing-List: contact bloodhound-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
List-Help: <mailto:bloodhound-commits-help@incubator.apache.org>
List-Unsubscribe: <mailto:bloodhound-commits-unsubscribe@incubator.apache.org>
List-Post: <mailto:bloodhound-commits@incubator.apache.org>
List-Id: <bloodhound-commits.incubator.apache.org>
Reply-To: bloodhound-dev@incubator.apache.org
Delivered-To: mailing list bloodhound-commits@incubator.apache.org
Received: (qmail 98719 invoked by uid 99); 14 Jun 2012 09:55:04 -0000
Received: from bloodhound-vm.apache.org (HELO bloodhound-vm) (140.211.11.32)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jun 2012 09:55:04 +0000
Received: from bloodhound-vm.apache.org (localhost [127.0.0.1])
	by bloodhound-vm (Postfix) with ESMTP id 81A43809D4;
	Thu, 14 Jun 2012 09:55:03 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: "Apache Bloodhound" <bloodhound-dev@incubator.apache.org>
X-Trac-Version: 0.13dev-r10952
Cc: bloodhound-commits@incubator.apache.org
Auto-Submitted: auto-generated
X-Mailer: Trac 0.13dev-r10952, by Edgewall Software
X-Trac-Project: Apache Bloodhound
Date: Thu, 14 Jun 2012 09:55:01 -0000
Reply-To: bloodhound-dev@incubator.apache.org
X-URL: https://issues.apache.org/bloodhound/
Subject: Re: [Apache Bloodhound] #77: Wrong version of bootstrap in
 dashboard plugins
X-Trac-Ticket-URL: https://issues.apache.org/bloodhound/ticket/77#comment:11
Message-ID: <067.6c1ce06c544d7b40b7523302606d3e74@incubator.apache.org>
References: <052.513dce5e7ca5b82ad271a96fb0aa9de9@incubator.apache.org>
X-Trac-Ticket-ID: 77
In-Reply-To: <052.513dce5e7ca5b82ad271a96fb0aa9de9@incubator.apache.org>

#77: Wrong version of bootstrap in dashboard plugins
------------------------+-------------------------------------
  Reporter:  gjm        |      Owner:  olemis
      Type:  defect     |     Status:  accepted
  Priority:  critical   |  Milestone:  RC1 for initial release
 Component:  dashboard  |    Version:
Resolution:             |   Keywords:
------------------------+-------------------------------------

Comment (by gjm):

 Replying to [comment:9 olemis]:
 > Patch is tiny indeed . I think we should consider forwarding it to
 Bootstrap to see whether they'll include it or not . Solution is quite
 generic as it only uses `jquery.closest` rather than `jquery.parent` to
 limit the scope of radio groups .

 I am not convinced that is correct though. What would be wrong with this:

 {{{
 #!diff
 Index: bhdashboard/layouts/templates/bs_btnbar.html
 ===================================================================
 --- bhdashboard/layouts/templates/bs_btnbar.html        (revision 1349952)
 +++ bhdashboard/layouts/templates/bs_btnbar.html        (working copy)
 @@ -6,8 +6,8 @@

    <xi:include href="widget_macros.html" />

 -  <div class="btn-toolbar" data-toggle="buttons-radio">
 -    <div class="btn-group offset1"
 +  <div class="btn-toolbar">
 +    <div class="btn-group offset1" data-toggle="buttons-radio"
          py:for="g in layout.toolbar" >
        <button data-target="#tb-item-${tb_item.id}" data-toggle="tab"
            disabled="${tb_item.widget is None and 'true' or None}"
 Index: bhdashboard/htdocs/js/bootstrap-button.js
 ===================================================================
 --- bhdashboard/htdocs/js/bootstrap-button.js   (revision 1349952)
 +++ bhdashboard/htdocs/js/bootstrap-button.js   (working copy)
 @@ -51,7 +51,7 @@
    }

    Button.prototype.toggle = function () {
 -    var $parent = this.$element.closest('[data-toggle="buttons-radio"]')
 +    var $parent = this.$element.parent('[data-toggle="buttons-radio"]')

      $parent && $parent
        .find('.active')
 }}}

 I struggle to find a reason to justify looking beyond the parent for any
 case. It looks to me like the {{{data-toggle}}} attribute should be on the
 {{{DIV.btn-group}}}.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/77#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker