Return-Path: X-Original-To: apmail-incubator-bloodhound-commits-archive@minotaur.apache.org Delivered-To: apmail-incubator-bloodhound-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CAE95C0A9 for ; Mon, 7 May 2012 19:18:56 +0000 (UTC) Received: (qmail 98606 invoked by uid 500); 7 May 2012 19:18:56 -0000 Delivered-To: apmail-incubator-bloodhound-commits-archive@incubator.apache.org Received: (qmail 98582 invoked by uid 500); 7 May 2012 19:18:56 -0000 Mailing-List: contact bloodhound-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: bloodhound-dev@incubator.apache.org Delivered-To: mailing list bloodhound-commits@incubator.apache.org Received: (qmail 98573 invoked by uid 99); 7 May 2012 19:18:56 -0000 Received: from bloodhound-vm.apache.org (HELO bloodhound-vm) (140.211.11.32) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2012 19:18:56 +0000 Received: from bloodhound-vm.apache.org (localhost [127.0.0.1]) by bloodhound-vm (Postfix) with ESMTP id 1E623805CD; Mon, 7 May 2012 19:18:55 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit From: "Apache Bloodhound" X-Trac-Version: 0.13dev-r10952 Cc: bloodhound-commits@incubator.apache.org Auto-Submitted: auto-generated X-Mailer: Trac 0.13dev-r10952, by Edgewall Software X-Trac-Project: Apache Bloodhound Date: Mon, 07 May 2012 19:18:54 -0000 Reply-To: bloodhound-dev@incubator.apache.org X-URL: https://issues.apache.org/bloodhound/ Subject: Re: [Apache Bloodhound] #40: Merge existing plugins into a single Bloodhound UI plugin X-Trac-Ticket-URL: https://issues.apache.org/bloodhound/ticket/40#comment:6 Message-ID: <070.87dc49bef1cd94daca44add56c3ee096@incubator.apache.org> References: <055.38fd679bd5c72b12a69e21f244cf9d40@incubator.apache.org> X-Trac-Ticket-ID: 40 In-Reply-To: <055.38fd679bd5c72b12a69e21f244cf9d40@incubator.apache.org> #40: Merge existing plugins into a single Bloodhound UI plugin --------------------------+----------------------------------- Reporter: olemis | Owner: nobody Type: enhancement | Status: new Priority: minor | Milestone: Component: dashboard | Version: Resolution: | Keywords: dashboard theme merge --------------------------+----------------------------------- Comment (by olemis): Let me explain myself better , and maybe it will be more clear why I'm requesting to merge them into a single package (e.g. '''.egg''' file) rather than e.g. splitting them into three . It is a fact that there are some ''Genshi'' templates common to both dashboard and theme . Nonetheless any one of them should not be a requirement to use the other as they may be (enabled | disabled) independently . Hence the idea is : 1. to distribute them in a single package (which also means that common templates are at a single location within distribution ''';)''' 2. make both , theme and dashboard check whether the other is enabled or not so as to ensure common templates location will always be available 3. ... and '''(2)''' can happen with eyes closed (i.e. no further checking ... ) due to the fact that those files will always be there because a package is distributed as a whole ; hence all parts of it are deployed together everywhere . ... otherwise afaics there are two scenarios : 1. copies of common templates are distributed in each package ( i.e. duplicated source code ... something I do not like ) 2. both , dashboard and theme depend upon a third component in a separate package that should be (installed | enabled | ...) but maybe not . Therefore additional checks will be needed with extra complexity involved. Finally both #51 and #54 are dependent on this because the template(s) needed to render the results of executing custom queries and reports is already implemented in dashboard plugin . They are used by respective widgets which were needed before to implement previous designs . These templates now need to be available so that theme code will be able to reuse them when rendering web UI . That's another reason to merge both plugins . -- Ticket URL: Apache Bloodhound The Apache Bloodhound (incubating) issue tracker