bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #40: Merge existing plugins into a single Bloodhound UI plugin
Date Mon, 07 May 2012 19:18:54 GMT
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
  Reporter:  olemis       |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  minor        |  Milestone:
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  dashboard theme merge
--------------------------+-----------------------------------

Comment (by olemis):

 Let me explain myself better , and maybe it will be more clear why I'm
 requesting to merge them into a single package (e.g. '''.egg''' file)
 rather than e.g. splitting them into three .

 It is a fact that there are some ''Genshi'' templates common to both
 dashboard and theme . Nonetheless any one of them should not be a
 requirement to use the other as they may be (enabled | disabled)
 independently . Hence the idea is :

   1. to distribute them in a single package
      (which also means that common templates are at a
      single location within distribution ''';)'''
   2. make both , theme and dashboard check whether
      the other is enabled or not so as to ensure
      common templates location will always be available
   3. ... and '''(2)''' can happen with eyes closed
      (i.e. no further checking ... ) due to the fact that
      those files will always be there because a package
      is distributed as a whole ; hence all parts of it
      are deployed together everywhere .

 ... otherwise afaics there are two scenarios :

   1. copies of common templates are distributed in each package
      ( i.e. duplicated source code ... something I do not like )
   2. both , dashboard and theme depend upon a third component
      in a separate package that should be
      (installed | enabled | ...) but maybe not . Therefore
      additional checks will be needed with extra complexity involved.

 Finally both #51 and #54 are dependent on this because the template(s)
 needed to render the results of executing custom queries and reports is
 already implemented in dashboard plugin . They are used by respective
 widgets which were needed before to implement previous designs . These
 templates now need to be available so that theme code will be able to
 reuse them when rendering web UI . That's another reason to merge both
 plugins .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message