bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #79: Generic conversion of menu of admin pages (admin theme) for unknown plugins to use bootstrap
Date Wed, 23 May 2012 07:48:29 GMT
#79: Generic conversion of menu of admin pages (admin theme) for unknown plugins
to use bootstrap
------------------------+----------------------
  Reporter:  gjm        |      Owner:  olemis
      Type:  task       |     Status:  accepted
  Priority:  major      |  Milestone:
 Component:  dashboard  |    Version:
Resolution:             |   Keywords:
------------------------+----------------------

Comment (by olemis):

 Your solution is so cool that I reviewed it once again Then I noticed it
 could be enhanced a bit further (after experimenting a little with Genshi
 templates and getting confirmation of the fact that some advanced tricks
 just work as I expected ''';)''' . So I attached two more patches (built
 against r1341394 ). They are explained below .

 [attachment:t79_r1341394_duplicate_tabcontent.diff First patch] fixes a
 minor bug. When modifying legacy (unsupported) admin page your patch
 renders ''HTML'' similar to the following snippet:

 {{{
 #!html

 <!-- Head , body , ... -->
 <div id="tabcontent" class="span9">
   <div id="tabcontent">
     <!-- Plugin-specific admin form -->
   </div>
 </div>
 <!-- ... everything else ... -->

 }}}

 Notice that `DIV#tabcontent` is inserted twice . After applying this patch
 , it looks likes this

 {{{
 #!html

 <!-- Head , body , ... -->
 <div id="tabcontent" class="span9">
   <!-- Plugin-specific admin form -->
 </div>
 <!-- ... everything else ... -->

 }}}

 Beyond that , I also noticed that after applying your initial patch ,
 admin template code is scattered.
 I mean you get exactly the same code (e.g. admin nav list) in two
 different files
 (i.e. `bloodhound_theme.html` and `bh_admin.html`) in order to render
 semantically equivalent web UI items.

 [attachment:t79_r1341394_single_admin_theme.diff Second patch] is aimed at
 having a single copy of code at a
 single location by including `bh_admin.html` directly rather that
 `bloodhound_admin_theme.html`
 with `bh_fix_legacy` flag set. This makes it possible to select correct
 match for unsupported
 and translated templates.

 Finally patch order is as follows

 {{{
 #!sh

 $ hg qapplied
 t79/t79_r1341394_match_admin_by_id.diff
 t79/t79_r1341394_duplicate_tabcontent.diff
 t79/t79_r1341394_single_admin_theme.diff

 }}}

 Feedback appreciated.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/79#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message