bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #87: Generic conversion of menu for preference pages for unknown plugins to use bootstrap
Date Wed, 23 May 2012 08:09:50 GMT
#87: Generic conversion of menu for preference pages for unknown plugins to use
bootstrap
--------------------------+--------------------------------------
  Reporter:  gjm          |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:  RC1 for initial release
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  theme preferences plugin
--------------------------+--------------------------------------

Comment (by olemis):

 Two patches attached to this ticket .

 The [attachment:t87_r1341394_prefs_legacy.diff first one] implements
 generic conversion of preferences pages by following the guidelines
 explained in [comment:ticket:79:8 my previous comment] posted to #79 so as
 to prevent scattering . In order to illustrate the result , this is what
 [http://trac-hacks.org/wiki/GrowlPlugin#Configuration Growl preferences
 panel] looks like before applying patch ...

 [[Image(bh_theme_x_31_growl_prefs_before.png, width=600)]]

 ... and next image illustrates the result after applying it .

 [[Image(bh_theme_x_32_growl_prefs_after.png, width=600)]]

 [attachment:t87_r1341394_theme_extensions.diff Second patch] suggests
 including an extension point so as to inject custom templates dynamically
 while rendering `bloodhound_theme.html`. This might be useful later in
 order to handle similar scenarios without modifying template code
 directly. Besides there's another open subject related to performance .
 Extension point makes possible to reduce the number of xtension templates
 injected in theme template according to the context as explained in the
 following snippet :

 {{{
 #!python

     def get_theme_templates(self, req, template, data, content_type):
         """List templates that will be included dynamically in theme
 template.
         So far they consist of :

         - Generic admin template for unsupported admin panels
         - Generic prefs template for unsupported preferences panels
         """
         # TODO: Reduce the number of templates applied by matching
 req.path_info
         # e.g. if this is an admin page do not include prefs template ,
         # OTOH if neither an admin nor prefs page why bother
         # including any of them. This might improve performance.
         yield 'bh_admin.html'
         yield 'bh_prefs.html'

 }}}

 Both patches are built on top of those attached to #79 , and should be
 applied against r1341394 in the following order.

 {{{
 #!sh

 $ hg qapplied
 t79/t79_r1341394_match_admin_by_id.diff
 t79/t79_r1341394_duplicate_tabcontent.diff
 t79/t79_r1341394_single_admin_theme.diff
 t87/t87_r1341394_prefs_legacy.diff
 t87/t87_r1341394_theme_extensions.diff

 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/87#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message