bloodhound-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Bloodhound" <bloodhound-...@incubator.apache.org>
Subject Re: [Apache Bloodhound] #79: Generic conversion of menu of admin pages (admin theme) for unknown plugins to use bootstrap
Date Mon, 21 May 2012 03:55:41 GMT
#79: Generic conversion of menu of admin pages (admin theme) for unknown plugins
to use bootstrap
------------------------+----------------------
  Reporter:  gjm        |      Owner:  olemis
      Type:  task       |     Status:  accepted
  Priority:  major      |  Milestone:
 Component:  dashboard  |    Version:
Resolution:             |   Keywords:
------------------------+----------------------

Comment (by olemis):

 The idea is valid afaics . Nonetheless it seems to me this is a chicken-
 egg situation. The question is :

 Where would you place that snippet ?

 AFAICS not in plugin-specific admin template (considering the hypothesis
 that solution must be generic so as to work with any existing plugin-
 specific admin template ). If so (cmiiw) those rules should be inserted in
 a different template we will provide . How will we invoke those rules when
 plugin request handler returns `(plugin_template.html, data,
 content_type)` ... I see no way to trigger your snippet other than doing
 what we do nowadays by using request filters . Considering the fact that
 we are looking for a way to provide a fallback strategy to deal with
 plugins for which no conversion to bootstrap exists ... I'm under the
 impression that your suggestion , even if it seems to be correct , but
 doesn't fit when we mention that last requirement ; due to the fact (I
 repeat ... cmiiw ''';)''' that those rules will never be executed if
 plugin-specific ''Genshi'' template is rendered (hence the need to do what
 we do today with request filters ...) .

 I've been thinking of using stream filters instead . But that's definitely
 a more complex approach .

 ... well ... that's just my initial $0.02 ''';)'''

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/79#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Mime
View raw message