Return-Path: 
 <user-return-183-apmail-bigtop-user-archive=bigtop.apache.org@bigtop.apache.org>
X-Original-To: apmail-bigtop-user-archive@www.apache.org
Delivered-To: apmail-bigtop-user-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A5D92D23D
	for <apmail-bigtop-user-archive@www.apache.org>;
 Wed, 28 Nov 2012 01:08:29 +0000 (UTC)
Received: (qmail 68322 invoked by uid 500); 28 Nov 2012 01:08:29 -0000
Delivered-To: apmail-bigtop-user-archive@bigtop.apache.org
Received: (qmail 68234 invoked by uid 500); 28 Nov 2012 01:08:28 -0000
Mailing-List: contact user-help@bigtop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:user-help@bigtop.apache.org>
List-Unsubscribe: <mailto:user-unsubscribe@bigtop.apache.org>
List-Post: <mailto:user@bigtop.apache.org>
List-Id: <user.bigtop.apache.org>
Reply-To: user@bigtop.apache.org
Delivered-To: mailing list user@bigtop.apache.org
Received: (qmail 68225 invoked by uid 99); 28 Nov 2012 01:08:28 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Nov 2012 01:08:28 +0000
X-ASF-Spam-Status: No, hits=1.5 required=5.0
	tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of grover.markgrover@gmail.com
 designates 209.85.220.178 as permitted sender)
Received: from [209.85.220.178] (HELO mail-vc0-f178.google.com)
 (209.85.220.178)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Nov 2012 01:08:21 +0000
Received: by mail-vc0-f178.google.com with SMTP id p16so8909286vcq.23
        for <user@bigtop.apache.org>; Tue, 27 Nov 2012 17:08:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=T3/TgUVWeX4SJsp24pdDkuxKUU7ZiOQ9umPlIsPJPRg=;
        b=Q1j3L50kj14sSR6sVKFVAeBO9Nnn22NRFTsNuqxZMPctGxKQTPkHO6K1MHcbtHRrRe
         DZxCtbwrJ5DOWJAxzYjT8hZWotn3ZauyJ2T/sqxngoxIlT/1sKEg/8v+1rSyK6E1pwcm
         LbqxXH4jntQipZAZ9501Oyya+zUNHK17jKQdKSYZyWRFgl3IggTXbLqJdZP2NRfKL4Rr
         4Df69Z/KaqcYpazbAE6bqsFJcvf5WjAf1hSFTtlYwQsqSgg8JROShzbW7EgTGEMkI2pf
         UarB41D1rK9vmXXzFBkgQrpVIY9Cjumg7gdhEjOcYZBb/hr9j7w2KqNuQPhBEk4j6143
         fgNQ==
MIME-Version: 1.0
Received: by 10.52.35.129 with SMTP id h1mr23668225vdj.74.1354064881239; Tue,
 27 Nov 2012 17:08:01 -0800 (PST)
Received: by 10.52.96.201 with HTTP; Tue, 27 Nov 2012 17:08:01 -0800 (PST)
Date: Tue, 27 Nov 2012 17:08:01 -0800
Message-ID: 
 <CAKm=R7XRmTM4nnjOo+_wv0RhGwvjQMdAys6PZ44Mp52FzhNd3A@mail.gmail.com>
Subject: Code review tools
From: Mark Grover <grover.markgrover@gmail.com>
To: user@bigtop.apache.org
Content-Type: multipart/alternative; boundary=20cf3079b9043fc67a04cf83cc56
X-Virus-Checked: Checked by ClamAV on apache.org

--20cf3079b9043fc67a04cf83cc56
Content-Type: text/plain; charset=ISO-8859-1

Hi all,
When reviewing Bigtop patches, I often find myself downloading the patch,
applying it to my local repo and using a diff tool on my computer to review
the patch (and have some context around it). I know for a fact that some of
the other Apache projects are very good about asking people to post reviews
on reviewboard (or something similar) when uploading a new patch. That
makes the process of reviewing the diff and commenting on patches much
easier.

Would it make sense for us to start leveraging something like
https://reviews.apache.org/dashboard/ for this?

Thoughts?

Mark

--20cf3079b9043fc67a04cf83cc56
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<span style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:1=
2.727272033691406px;background-color:rgb(255,255,255)">Hi all,</span><div s=
tyle=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.72727=
2033691406px;background-color:rgb(255,255,255)">
When reviewing Bigtop patches, I often find myself downloading the patch, a=
pplying it to my local repo and using a diff tool on my computer to review =
the patch (and have some context around it). I know for a fact that some of=
 the other Apache projects are very good about asking people to post review=
s on reviewboard (or something similar) when uploading a new patch. That ma=
kes the process of reviewing the diff and commenting on patches much easier=
.</div>
<div style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12=
.727272033691406px;background-color:rgb(255,255,255)"><br></div><div style=
=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.727272033=
691406px;background-color:rgb(255,255,255)">
Would it make sense for us to start leveraging something like=A0<a href=3D"=
https://reviews.apache.org/dashboard/" target=3D"_blank" style=3D"color:rgb=
(17,85,204)">https://reviews.apache.org/dashboard/</a>=A0for this?=A0</div>=
<div style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12=
.727272033691406px;background-color:rgb(255,255,255)">
<br></div><div style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;fo=
nt-size:12.727272033691406px;background-color:rgb(255,255,255)">Thoughts?</=
div><div style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-siz=
e:12.727272033691406px;background-color:rgb(255,255,255)">
<br></div><div style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;fo=
nt-size:12.727272033691406px;background-color:rgb(255,255,255)">Mark</div>

--20cf3079b9043fc67a04cf83cc56--